public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cho KyongHo <pullip.cho@samsung.com>
To: "'Linux ARM Kernel'" <linux-arm-kernel@lists.infradead.org>,
	"'Linux IOMMU'" <iommu@lists.linux-foundation.org>,
	"'Linux Kernel'" <linux-kernel@vger.kernel.org>,
	"'Linux Samsung SOC'" <linux-samsung-soc@vger.kernel.org>
Cc: "'Hyunwoong Kim'" <khw0178.kim@samsung.com>,
	"'Joerg Roedel'" <joro@8bytes.org>,
	"'Kukjin Kim'" <kgene.kim@samsung.com>,
	"'Prathyush'" <prathyush.k@samsung.com>,
	"'Rahul Sharma'" <rahul.sharma@samsung.com>,
	"'Subash Patel'" <supash.ramaswamy@linaro.org>,
	"'Keyyoung Park'" <keyyoung.park@samsung.com>,
	"'Grant Grundler'" <grundler@chromium.org>,
	"'Antonios Motakis'" <a.motakis@virtualopensystems.com>,
	kvmarm@lists.cs.columbia.edu,
	"'Sachin Kamat'" <sachin.kamat@linaro.org>
Subject: [PATCH v8 02/12] iommu/exynos: add missing cache flush for removed page table entries
Date: Fri, 26 Jul 2013 20:26:28 +0900	[thread overview]
Message-ID: <003801ce89f2$f8952d20$e9bf8760$@samsung.com> (raw)

This commit adds cache flush for removed small and large page entries
in exynos_iommu_unmap(). Missing cache flush of removed page table
entries can cause missing page fault interrupt when a master IP
accesses an unmapped area.

Signed-off-by: Cho KyongHo <pullip.cho@samsung.com>
---
 drivers/iommu/exynos-iommu.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 233f382..e3be3e5 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -1002,6 +1002,7 @@ static size_t exynos_iommu_unmap(struct iommu_domain *domain,
 	if (lv2ent_small(ent)) {
 		*ent = 0;
 		size = SPAGE_SIZE;
+		pgtable_flush(ent, ent +1);
 		priv->lv2entcnt[lv1ent_offset(iova)] += 1;
 		goto done;
 	}
@@ -1010,6 +1011,7 @@ static size_t exynos_iommu_unmap(struct iommu_domain *domain,
 	BUG_ON(size < LPAGE_SIZE);
 
 	memset(ent, 0, sizeof(*ent) * SPAGES_PER_LPAGE);
+	pgtable_flush(ent, ent + SPAGES_PER_LPAGE);
 
 	size = LPAGE_SIZE;
 	priv->lv2entcnt[lv1ent_offset(iova)] += SPAGES_PER_LPAGE;
-- 
1.7.2.5



             reply	other threads:[~2013-07-26 11:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 11:26 Cho KyongHo [this message]
2013-07-26 15:58 ` [PATCH v8 02/12] iommu/exynos: add missing cache flush for removed page table entries Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003801ce89f2$f8952d20$e9bf8760$@samsung.com' \
    --to=pullip.cho@samsung.com \
    --cc=a.motakis@virtualopensystems.com \
    --cc=grundler@chromium.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=keyyoung.park@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=khw0178.kim@samsung.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=prathyush.k@samsung.com \
    --cc=rahul.sharma@samsung.com \
    --cc=sachin.kamat@linaro.org \
    --cc=supash.ramaswamy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox