From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Park Ju Hyung'" <qkrwngud825@gmail.com>
Cc: "'Sungjong Seo'" <sj1557.seo@samsung.com>,
"'open list'" <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
Subject: RE: [PATCH] exfat: implement "quiet" option for setattr
Date: Thu, 2 Jul 2020 14:16:34 +0900 [thread overview]
Message-ID: <003801d6502f$f40101c0$dc030540$@samsung.com> (raw)
In-Reply-To: <20200627125509.142393-1-qkrwngud825@gmail.com>
>
> if (((attr->ia_valid & ATTR_UID) &&
> !uid_eq(attr->ia_uid, sbi->options.fs_uid)) || @@ -322,6 +325,12 @@ int
> exfat_setattr(struct dentry *dentry, struct iattr *attr)
> goto out;
You should remove goto statement and curly braces here to reach if error condition.
> }
>
> + if (error) {
> + if (sbi->options.quiet)
> + error = 0;
> + goto out;
> + }
next prev parent reply other threads:[~2020-07-02 5:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200627125605epcas1p175ba4ecfbdea3426cc7b0a8fc1750cd0@epcas1p1.samsung.com>
2020-06-27 12:55 ` [PATCH] exfat: implement "quiet" option for setattr Park Ju Hyung
2020-07-02 5:16 ` Namjae Jeon [this message]
2020-07-06 8:22 ` Ju Hyung Park
2020-07-06 10:26 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003801d6502f$f40101c0$dc030540$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qkrwngud825@gmail.com \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox