From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Nicholas Krause'" <xerofoify@gmail.com>, <swise@chelsio.com>
Cc: <dledford@redhat.com>, <sean.hefty@intel.com>,
<hal.rosenstock@gmail.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool
Date: Thu, 16 Jul 2015 13:40:41 -0500 [thread overview]
Message-ID: <003901d0bff6$eb0aadb0$c1200910$@opengridcomputing.com> (raw)
In-Reply-To: <1437071644-23895-1-git-send-email-xerofoify@gmail.com>
Is this change really worth the effort?
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Thursday, July 16, 2015 1:34 PM
> To: swise@chelsio.com
> Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool
>
> This makes the function rdma_supported have a return type of bool
> due to this particular function's return statement always returning
> either one or zero as its return value.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/infiniband/hw/cxgb4/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 1a29739..285f6606 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -912,7 +912,7 @@ static void c4iw_remove(struct uld_ctx *ctx)
> c4iw_dealloc(ctx);
> }
>
> -static int rdma_supported(const struct cxgb4_lld_info *infop)
> +static bool rdma_supported(const struct cxgb4_lld_info *infop)
> {
> return infop->vr->stag.size > 0 && infop->vr->pbl.size > 0 &&
> infop->vr->rq.size > 0 && infop->vr->qp.size > 0 &&
> --
> 2.1.4
parent reply other threads:[~2015-07-16 18:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1437071644-23895-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003901d0bff6$eb0aadb0$c1200910$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox