From: Florian Eckert <fe@dev.tdt.de>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org,
pavel@ucw.cz, lee@kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, Eckert.Florian@googlemail.com
Subject: Re: [PATCH 1/2] tty: new helper function tty_get_mget
Date: Tue, 14 Feb 2023 10:17:56 +0100 [thread overview]
Message-ID: <00390b00bf50f42ff112ee8e31b88c8d@dev.tdt.de> (raw)
In-Reply-To: <5f67e2cf-f141-fde4-96de-28ceeeec9c06@kernel.org>
>> --- a/include/linux/tty.h
>> +++ b/include/linux/tty.h
>> @@ -419,8 +419,9 @@ void tty_unthrottle(struct tty_struct *tty);
>> int tty_throttle_safe(struct tty_struct *tty);
>> int tty_unthrottle_safe(struct tty_struct *tty);
>> int tty_do_resize(struct tty_struct *tty, struct winsize *ws);
>> -int tty_get_icount(struct tty_struct *tty,
>> +int tty_get_icount(struct tty_struct *tty
>
> The robot already complained about this ^^^.
>
> Have you even tried to compile-test this?
Sorry I made a rebase of the patch set. My mistake!
I compiled and tested my changes against kernel 5.15 (OpenWrt).
And it worked as expected.
>
>> struct serial_icounter_struct *icount);
>> +extern int tty_get_mget(struct tty_struct *tty);
>
next prev parent reply other threads:[~2023-02-14 9:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 14:06 [PATCH 0/2] leds: ledtrig-tty: mode xtension Florian Eckert
2023-02-13 14:06 ` [PATCH 1/2] tty: new helper function tty_get_mget Florian Eckert
2023-02-13 19:25 ` kernel test robot
2023-02-13 19:25 ` kernel test robot
2023-02-13 21:28 ` kernel test robot
2023-02-13 21:49 ` kernel test robot
2023-02-14 7:41 ` Jiri Slaby
2023-02-14 9:17 ` Florian Eckert [this message]
2023-02-13 14:06 ` [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes Florian Eckert
2023-02-14 7:54 ` Jiri Slaby
2023-02-14 11:13 ` Florian Eckert
2023-02-16 6:45 ` Jiri Slaby
2023-02-14 10:11 ` Uwe Kleine-König
2023-02-14 10:48 ` Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00390b00bf50f42ff112ee8e31b88c8d@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox