The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>,
	marcel@holtmann.org, luiz.dentz@gmail.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, amitkumar.karwar@nxp.com,
	sherry.sun@nxp.com, ziniu.wang_1@nxp.com,
	johan.korsnes@remarkable.no, kristian.krohn@remarkable.no,
	manjeet.gupta@nxp.com
Subject: Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address
Date: Tue, 14 Jan 2025 14:39:11 +0100	[thread overview]
Message-ID: <003b6048-eb38-4bbc-8c83-31d45f0db46d@kernel.org> (raw)
In-Reply-To: <20250114133548.2362038-1-neeraj.sanjaykale@nxp.com>

On 14/01/2025 14:35, Neeraj Sanjay Kale wrote:
> This adds a new optional device tree property local-bd-address to allow

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> user to set custom BD address for NXP chipsets.


> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
> v2: Add allOf and unevaluatedProperties: false (Krzysztof)
> --- 
>  .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 0a2d7baf5db3..5d75a45cac14 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -17,6 +17,9 @@ description:
>  maintainers:
>    - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
>  
> +allOf:
> +  - $ref: bluetooth-controller.yaml#
> +
>  properties:
>    compatible:
>      enum:
> @@ -40,10 +43,12 @@ properties:
>        Host-To-Chip power save mechanism is driven by this GPIO
>        connected to BT_WAKE_IN pin of the NXP chipset.
>  
> +  local-bd-address: true

In case I was not clear: drop. And rephrase the commit msg to reflect this.

Best regards,
Krzysztof

  parent reply	other threads:[~2025-01-14 13:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-14 13:35 [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address Neeraj Sanjay Kale
2025-01-14 13:35 ` [PATCH v2 2/2] Bluetooth: btnxpuart: Add support for " Neeraj Sanjay Kale
2025-01-14 13:53   ` Johan Korsnes
2025-01-14 14:07     ` Neeraj Sanjay Kale
2025-01-14 14:09       ` Johan Korsnes
2025-01-14 13:39 ` Krzysztof Kozlowski [this message]
2025-01-14 14:21   ` [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support to " Neeraj Sanjay Kale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=003b6048-eb38-4bbc-8c83-31d45f0db46d@kernel.org \
    --to=krzk@kernel.org \
    --cc=amitkumar.karwar@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan.korsnes@remarkable.no \
    --cc=kristian.krohn@remarkable.no \
    --cc=krzk+dt@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=manjeet.gupta@nxp.com \
    --cc=marcel@holtmann.org \
    --cc=neeraj.sanjaykale@nxp.com \
    --cc=robh@kernel.org \
    --cc=sherry.sun@nxp.com \
    --cc=ziniu.wang_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox