From: "Misha Tomushev" <misha@fabric7.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>
Cc: <jgarzik@pobox.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] VIOC: New Network Device Driver
Date: Mon, 11 Sep 2006 10:58:23 -0700 [thread overview]
Message-ID: <003c01c6d5cb$e00fd850$7501a8c0@ZINLAPTOP> (raw)
In-Reply-To: <200609102339.25621.arnd@arndb.de>
-----Original Message-----
From: Arnd Bergmann [mailto:arnd@arndb.de]
Sent: Sunday, September 10, 2006 2:39 PM
To: Misha Tomushev
Cc: jgarzik@pobox.com; netdev@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] VIOC: New Network Device Driver
Am Friday 15 September 2006 02:15 schrieb Misha Tomushev:
> VIOC Device Driver provides a standard device interface to the
internal
> fabric interconnected network used on servers designed and built by
> Fabric 7 Systems.
>
> The patch can be found at ftp.fabric7.com/VIOC.
We recently had a discussion about tx descriptor cleanup in general.
It would probably be more efficient to call vnic_clean_txq from the
vioc_rx_poll() function. To do that, your tx interrupt handler
should disable the tx interrupt line and call netif_rx_schedule,
like you do for the receive interrupts.
The descriptor clean-up does not contribute anything to the performance
of the driver, it just replenishes the memory pools. It almost does not
need interrupts. Why would we want to add more cycles to the receive
logic, when driver is doing useful work for something that can run
almost at any time?
next prev parent reply other threads:[~2006-09-11 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 0:15 [PATCH] VIOC: New Network Device Driver Misha Tomushev
2006-09-10 10:50 ` Jan-Benedict Glaw
2006-09-10 21:39 ` Arnd Bergmann
2006-09-10 22:21 ` Francois Romieu
2006-09-11 17:58 ` Misha Tomushev [this message]
2006-09-11 19:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003c01c6d5cb$e00fd850$7501a8c0@ZINLAPTOP' \
--to=misha@fabric7.com \
--cc=arnd@arndb.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox