From: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: "Wolfgang Grandegger" <wg@grandegger.com>,
"Wolfram Sang" <w.sang@pengutronix.de>,
"Christian Pellegrin" <chripell@fsfe.org>,
"Barry Song" <21cnbao@gmail.com>,
"Samuel Ortiz" <sameo@linux.intel.com>,
<socketcan-core@lists.berlios.de>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
<andrew.chih.howe.khor@intel.com>, <qi.wang@intel.com>,
<margie.foster@intel.com>, <yong.y.wang@intel.com>,
<kok.howg.ewe@intel.com>, <joel.clark@intel.com>
Subject: Re: [PATCH net-next-2.6 06/19 v5] can: EG20T PCH: Fix endianness issue
Date: Mon, 29 Nov 2010 09:19:13 +0900 [thread overview]
Message-ID: <003c01cb8f5b$0f13e8b0$66f8800a@maildom.okisemi.com> (raw)
In-Reply-To: 4CEF835C.7000304@pengutronix.de
On Friday, November 26, 2010 6:52 PM, Marc Kleine-Budde wrote :
> In an OOM situation the system is under pressure anyway. On low end
> systems it not good to print a message to the log. AFAICS no other can
> driver does this.
Does the above mean it doesn't have to process for returned value of
pch_can_rx_msg_lost like below?
> + pch_can_rx_msg_lost(ndev, obj_num);
> + rcv_pkts++;
> + quota--;
> AFAICS no other can driver does this.
I can see ti_hecc.c calls dev_err when alloc_can_err_skb fails.
Thanks,
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.
prev parent reply other threads:[~2010-11-29 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 2:12 [PATCH net-next-2.6 06/19 v5] can: EG20T PCH: Fix endianness issue Tomoya MORINAGA
2010-11-26 9:52 ` Marc Kleine-Budde
2010-11-29 0:19 ` Tomoya MORINAGA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003c01cb8f5b$0f13e8b0$66f8800a@maildom.okisemi.com' \
--to=tomoya-linux@dsn.okisemi.com \
--cc=21cnbao@gmail.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=w.sang@pengutronix.de \
--cc=wg@grandegger.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox