From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933146AbcH2O0C (ORCPT ); Mon, 29 Aug 2016 10:26:02 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:52041 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757465AbcH2O0A (ORCPT ); Mon, 29 Aug 2016 10:26:00 -0400 From: "Steve Wise" To: "'Baoyou Xie'" , , , Cc: , , , References: <1472396231-16937-1-git-send-email-baoyou.xie@linaro.org> In-Reply-To: <1472396231-16937-1-git-send-email-baoyou.xie@linaro.org> Subject: RE: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp Date: Mon, 29 Aug 2016 09:26:01 -0500 Message-ID: <004001d20201$448119e0$cd834da0$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKC6W8Z6kPVjHjaMekOrcSmpXP3v57+L4kw Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp > > We get 1 warning when build kernel with W=1: > drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for > '_free_qp' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > Reviewed-by: Yuval Shaia > Reviewed-by: Leon Romanovsky Ignore my comment on v2... Acked-by: Steve Wise