* [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
@ 2016-08-28 14:57 Baoyou Xie
2016-08-29 14:26 ` Steve Wise
0 siblings, 1 reply; 3+ messages in thread
From: Baoyou Xie @ 2016-08-28 14:57 UTC (permalink / raw)
To: swise, dledford, sean.hefty, hal.rosenstock
Cc: linux-rdma, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when build kernel with W=1:
drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for '_free_qp' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared
and don't need a declaration, but can be made static.
so this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
---
drivers/infiniband/hw/cxgb4/qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index edb1172..6904352 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -683,7 +683,7 @@ static int build_inv_stag(union t4_wr *wqe, struct ib_send_wr *wr,
return 0;
}
-void _free_qp(struct kref *kref)
+static void _free_qp(struct kref *kref)
{
struct c4iw_qp *qhp;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
2016-08-28 14:57 [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp Baoyou Xie
@ 2016-08-29 14:26 ` Steve Wise
2016-09-02 17:23 ` Doug Ledford
0 siblings, 1 reply; 3+ messages in thread
From: Steve Wise @ 2016-08-29 14:26 UTC (permalink / raw)
To: 'Baoyou Xie', dledford, sean.hefty, hal.rosenstock
Cc: linux-rdma, linux-kernel, arnd, xie.baoyou
> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>
> We get 1 warning when build kernel with W=1:
> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
> '_free_qp' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Ignore my comment on v2...
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
2016-08-29 14:26 ` Steve Wise
@ 2016-09-02 17:23 ` Doug Ledford
0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2016-09-02 17:23 UTC (permalink / raw)
To: Steve Wise, 'Baoyou Xie', sean.hefty, hal.rosenstock
Cc: linux-rdma, linux-kernel, arnd, xie.baoyou
[-- Attachment #1.1: Type: text/plain, Size: 808 bytes --]
On 8/29/2016 10:26 AM, Steve Wise wrote:
>> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>>
>> We get 1 warning when build kernel with W=1:
>> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
>> '_free_qp' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is declared
>> and don't need a declaration, but can be made static.
>> so this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
>> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
>
> Ignore my comment on v2...
>
> Acked-by: Steve Wise <swise@opengridcomputing.com>
>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-02 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-28 14:57 [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp Baoyou Xie
2016-08-29 14:26 ` Steve Wise
2016-09-02 17:23 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox