Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp

Doug Ledford
2016-09-02T17:24:15Z

[-- Attachment #1.1: Type: text/plain, Size: 808 bytes --]

On 8/29/2016 10:26 AM, Steve Wise wrote:
>> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>>
>> We get 1 warning when build kernel with W=1:
>> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
>> '_free_qp' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is declared
>> and don't need a declaration, but can be made static.
>> so this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
>> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
>
> Ignore my comment on v2...
>
> Acked-by: Steve Wise <swise@opengridcomputing.com>
>

Thanks, applied.

--
Doug Ledford <dledford@redhat.com>
GPG Key ID: 0E572FDD

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]