[PATCH] drm/exynos: g2d: staticize stubs in header

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] drm/exynos: g2d: staticize stubs in header
@ 2023-05-07 14:47 ` Krzysztof Kozlowski
  2023-05-07 16:35   ` Alim Akhtar
  2023-05-15  4:13   ` Inki Dae
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-07 14:47 UTC (permalink / raw)
  To: Inki Dae, Seung-Woo Kim, Kyungmin Park, David Airlie,
	Daniel Vetter, Krzysztof Kozlowski, Alim Akhtar, Marek Szyprowski,
	dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel

Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
inline:

  drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous prototype for ‘g2d_open’ [-Wmissing-prototypes]
  drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous prototype for ‘g2d_close’ [-Wmissing-prototypes]

Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
index 74ea3c26dead..1a5ae781b56c 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
@@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct drm_device *dev, void *data,
 	return -ENODEV;
 }
 
-int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
+static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
 {
 	return 0;
 }
 
-void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
+static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
 { }
 #endif
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] drm/exynos: g2d: staticize stubs in header
  2023-05-07 14:47 ` [PATCH] drm/exynos: g2d: staticize stubs in header Krzysztof Kozlowski
@ 2023-05-07 16:35   ` Alim Akhtar
  2023-05-15  4:13   ` Inki Dae
  1 sibling, 0 replies; 4+ messages in thread
From: Alim Akhtar @ 2023-05-07 16:35 UTC (permalink / raw)
  To: 'Krzysztof Kozlowski', 'Inki Dae',
	'Seung-Woo Kim', 'Kyungmin Park',
	'David Airlie', 'Daniel Vetter',
	'Marek Szyprowski', dri-devel, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Sunday, May 7, 2023 8:18 PM
> To: Inki Dae <inki.dae@samsung.com>; Seung-Woo Kim
> <sw0312.kim@samsung.com>; Kyungmin Park
> <kyungmin.park@samsung.com>; David Airlie <airlied@gmail.com>; Daniel
> Vetter <daniel@ffwll.ch>; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>; Alim Akhtar <alim.akhtar@samsung.com>;
> Marek Szyprowski <m.szyprowski@samsung.com>; dri-
> devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/exynos: g2d: staticize stubs in header
> 
> Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
> inline:
> 
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous
> prototype for ‘g2d_open’ [-Wmissing-prototypes]
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous
> prototype for ‘g2d_close’ [-Wmissing-prototypes]
> 
> Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


>  drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> index 74ea3c26dead..1a5ae781b56c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct
> drm_device *dev, void *data,
>  	return -ENODEV;
>  }
> 
> -int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
>  {
>  	return 0;
>  }
> 
> -void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
>  { }
>  #endif
> --
> 2.34.1




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/exynos: g2d: staticize stubs in header
  2023-05-07 14:47 ` [PATCH] drm/exynos: g2d: staticize stubs in header Krzysztof Kozlowski
  2023-05-07 16:35   ` Alim Akhtar
@ 2023-05-15  4:13   ` Inki Dae
  2023-05-15  4:16     ` Inki Dae
  1 sibling, 1 reply; 4+ messages in thread
From: Inki Dae @ 2023-05-15  4:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Seung-Woo Kim, Kyungmin Park, David Airlie, Daniel Vetter,
	Alim Akhtar, Marek Szyprowski, dri-devel, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

Hi Krzysztof,

2023년 5월 7일 (일) 오후 11:48, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org>님이 작성:
>
> Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
> inline:

Same patch[1] was posted before so I picked up the previous one.

[1] [PATCH] drm/exynos: fix g2d_open/close helper function definitions
(kernel.org)

Thanks,
Inki Dae

>
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous prototype for ‘g2d_open’ [-Wmissing-prototypes]
>   drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous prototype for ‘g2d_close’ [-Wmissing-prototypes]
>
> Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> index 74ea3c26dead..1a5ae781b56c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct drm_device *dev, void *data,
>         return -ENODEV;
>  }
>
> -int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
>  {
>         return 0;
>  }
>
> -void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
>  { }
>  #endif
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/exynos: g2d: staticize stubs in header
  2023-05-15  4:13   ` Inki Dae
@ 2023-05-15  4:16     ` Inki Dae
  0 siblings, 0 replies; 4+ messages in thread
From: Inki Dae @ 2023-05-15  4:16 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Seung-Woo Kim, Kyungmin Park, David Airlie, Daniel Vetter,
	Alim Akhtar, Marek Szyprowski, dri-devel, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

2023년 5월 15일 (월) 오후 1:13, Inki Dae <daeinki@gmail.com>님이 작성:
>
> Hi Krzysztof,
>
> 2023년 5월 7일 (일) 오후 11:48, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>님이 작성:
> >
> > Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
> > inline:
>
> Same patch[1] was posted before so I picked up the previous one.
>
> [1] [PATCH] drm/exynos: fix g2d_open/close helper function definitions
> (kernel.org)

[1] https://lore.kernel.org/lkml/20230425165618.2ztg4mecuvpkdg3a@intel.intel/T/

Just corrected the link.

>
> Thanks,
> Inki Dae
>
> >
> >   drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous prototype for ‘g2d_open’ [-Wmissing-prototypes]
> >   drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous prototype for ‘g2d_close’ [-Wmissing-prototypes]
> >
> > Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> >  drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> > index 74ea3c26dead..1a5ae781b56c 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> > @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct drm_device *dev, void *data,
> >         return -ENODEV;
> >  }
> >
> > -int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> > +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> >  {
> >         return 0;
> >  }
> >
> > -void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> > +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> >  { }
> >  #endif
> > --
> > 2.34.1
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-05-15  4:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20230507144800epcas5p219717e5bf06b91772ee877c8dcee0940@epcas5p2.samsung.com>
2023-05-07 14:47 ` [PATCH] drm/exynos: g2d: staticize stubs in header Krzysztof Kozlowski
2023-05-07 16:35   ` Alim Akhtar
2023-05-15  4:13   ` Inki Dae
2023-05-15  4:16     ` Inki Dae

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox