RE: [PATCH 0/4] sched: Various reweight_entity() fixes

["Doug Smythies" <dsmythies@telus.net>]

On 2026.02.11 02:49 Peter Zijlstra wrote:
> On Wed, Feb 11, 2026 at 10:01:44AM +0100, Peter Zijlstra wrote:
>
>>> There 2 issues with patch 3
>>> 
>>> *one scale_load_down remains in avg_vruntime
>>> 
>>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>>> index 25c398ff0d59..3143ae7f07b0 100644
>>> --- a/kernel/sched/fair.c
>>> +++ b/kernel/sched/fair.c
>>> @@ -778,7 +778,7 @@ u64 avg_vruntime(struct cfs_rq *cfs_rq)
>>> 
>>>         if (weight) {
>>>                 if (curr) {
>>> -                       unsigned long w = scale_load_down(curr->load.weight);
>>> +                       unsigned long w =
>>> avg_vruntime_weight(curr->load.weight);
>>> 
>>>                         runtime += entity_key(cfs_rq, curr) * w;
>>>                         weight += w;
>> 
>> AAARGHHH!! Sorry about that, clearly I've not been careful with
>> reshuffling patches :-(
>
> So with that one fixed; I get (as queue/sched/core of just now):
> 
... snip...

For the Phoronix version of hackbench I now get (I call this "V3"):
Run 1 of 2, 10 tests per run: 22.875 seconds average, Deviation 0.25%
Run 2 of 2, 10 tests per run: 22.979 seconds average, Deviation 0.16%
Test conditions same as yesterday for "V2" (was 85.755 seconds average, deviation 3.33%)
Processor Test Configuration 8 and "Process".
Conclusion: great.

> Now let me go check on that latency thing from Doug (although hopefully
> that was the same boo-boo).

I am starting that test now.

... Doug