From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199AbcKUXyp (ORCPT ); Mon, 21 Nov 2016 18:54:45 -0500 Received: from cmta20.telus.net ([209.171.16.93]:49603 "EHLO cmta20.telus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753434AbcKUXyn (ORCPT ); Mon, 21 Nov 2016 18:54:43 -0500 X-Authority-Analysis: v=2.2 cv=Jo8elIwC c=1 sm=1 tr=0 a=zJWegnE7BH9C0Gl4FFgQyA==:117 a=zJWegnE7BH9C0Gl4FFgQyA==:17 a=Pyq9K9CWowscuQLKlpiwfMBGOR0=:19 a=IkcTkHD0fZMA:10 a=RhM3wYMJZSbzrQdg1fMA:9 a=QEXdDO2ut3YA:10 From: "Doug Smythies" To: "'Rafael J. Wysocki'" Cc: "'Srinivas Pandruvada'" , "'Linux Kernel Mailing List'" , "'Linux PM list'" References: 7V8gc8F0cCdRJ7V8lcAyAi In-Reply-To: 7V8gc8F0cCdRJ7V8lcAyAi Subject: RE: [PATCH v3] cpufreq: intel_pstate: Generic governors support Date: Mon, 21 Nov 2016 15:54:38 -0800 Message-ID: <004501d24452$a06d2440$e1476cc0$@net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdJBIa7TlyLSgB5oTxqtMm/9WTy+wwDMA1IA Content-Language: en-ca X-CMAE-Envelope: MS4wfEXt405jLLbra+E1BbClV09P5NZXDpKNe0QWOBIidJIGnrDPp/P+3LJ8Ozb1duF0DBaALchidkwqmeD++irzHpzjnFAF9ajDXqJc+KUlbhFgHnn+lYKj 2uAzbjz7o5845r37njfT/6zKQxMwJ49d7h/tM8MZEN1j02T4vVVSFqSR1du/tlA1/fXi+CJrF7CWV5XLNl8JrGq0JQbrJ1YALbgbIsogGxaPBvR4/dw2P/Zl JW74ihU1WmJV+LO1WNeTZK3iz3m7FwBkHVaxMgcGGaNdi/r5xOKG2LM5nS5z86Gf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016.11.17 14:34 Rafael J. Wysocki wrote: > v2 -> v3: > The previous iteration didn't work correcty if ondemand was the default > governor, because it didn't set policy->cur during initialization and > that caused cpufreq_dbs_governor_start() to return an error (thanks to > Srinovas for finding that bug). Just for the sake of due diligence: I re-tested v3 with all the same tests I had done with previous versions, with the same positive results that I got with v2. On my test computer, I also re-created the v2 failure discovered by Srinivas, and confirm it is O.K. with v3. On the v2 thread you said: > I'll add a Tested-by tag from you to it if you don't mind. That would be fine. ... Doug