* [PATCH 1/4] hwrng: atmel - remove unnecessary platform_set_drvdata()
@ 2013-05-06 4:37 Jingoo Han
2013-05-14 2:36 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 4:37 UTC (permalink / raw)
To: 'Herbert Xu'; +Cc: linux-kernel, 'Matt Mackall', Jingoo Han
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/char/hw_random/atmel-rng.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c
index 7c73d4a..bf9fc6b 100644
--- a/drivers/char/hw_random/atmel-rng.c
+++ b/drivers/char/hw_random/atmel-rng.c
@@ -108,8 +108,6 @@ static int atmel_trng_remove(struct platform_device *pdev)
clk_disable(trng->clk);
clk_put(trng->clk);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/4] hwrng: atmel - remove unnecessary platform_set_drvdata()
2013-05-06 4:37 [PATCH 1/4] hwrng: atmel - remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-14 2:36 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2013-05-14 2:36 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Matt Mackall'
On Mon, May 06, 2013 at 01:37:13PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
All applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-14 2:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 4:37 [PATCH 1/4] hwrng: atmel - remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-14 2:36 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox