* [PATCH] ARM: dts: Fix booting on Rinato market device @ 2014-11-07 11:44 Krzysztof Kozlowski 2014-11-07 11:50 ` Chanwoo Choi 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2014-11-07 11:44 UTC (permalink / raw) To: Ben Dooks, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel Cc: Krzysztof Kozlowski The bootloader on market Rinato (Gear 2) device checks for revision in compatible field of DTB. If it is not present or lower than required then booting fails with: "Could not do normal boot. (no DTB found)". Log of bootloader in case of failure: h/w: revision = 0x06 h/w: schematic = SM-R380_Rev0.5_Final_0205 date = 2000/01/01 12:00:21 (UTC) cmu_div:4, div:5, src_clk:800000000, pixel_clk:31860720 load_kernel: loading boot image from 57344.. (BOOT) load_kernel: found zImage, size: 0x3267e8 0xbc Error! Verify_Binary_Signature: failed. pit_check_signature (BOOT) invalid. load_kernel: found custom kernel (ret:-2147483647) No need to update kernel type. Detected board: samsung,rinato-rev06 Could not do normal boot. (no DTB found) : Entering usb mode for SM-R380_EUR_XX (65535).. Add a "rev06" suffix to compatible to satisfy the bootloader. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index 84380fa13e37..f72ba0a1d915 100644 --- a/arch/arm/boot/dts/exynos3250-rinato.dts +++ b/arch/arm/boot/dts/exynos3250-rinato.dts @@ -18,7 +18,8 @@ / { model = "Samsung Rinato board"; - compatible = "samsung,rinato", "samsung,exynos3250", "samsung,exynos3"; + compatible = "samsung,rinato", "samsung,rinato-rev06", + "samsung,exynos3250", "samsung,exynos3"; aliases { i2c7 = &i2c_max77836; -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: Fix booting on Rinato market device 2014-11-07 11:44 [PATCH] ARM: dts: Fix booting on Rinato market device Krzysztof Kozlowski @ 2014-11-07 11:50 ` Chanwoo Choi 2014-11-07 11:59 ` Krzysztof Kozlowski 0 siblings, 1 reply; 5+ messages in thread From: Chanwoo Choi @ 2014-11-07 11:50 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Ben Dooks, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel Hi Krzysztof, On 11/07/2014 08:44 PM, Krzysztof Kozlowski wrote: > The bootloader on market Rinato (Gear 2) device checks for revision in > compatible field of DTB. If it is not present or lower than required > then booting fails with: "Could not do normal boot. (no DTB found)". > > Log of bootloader in case of failure: > h/w: revision = 0x06 > h/w: schematic = SM-R380_Rev0.5_Final_0205 > date = 2000/01/01 12:00:21 (UTC) > cmu_div:4, div:5, src_clk:800000000, pixel_clk:31860720 > load_kernel: loading boot image from 57344.. (BOOT) > load_kernel: found zImage, size: 0x3267e8 > 0xbc Error! > Verify_Binary_Signature: failed. > pit_check_signature (BOOT) invalid. > load_kernel: found custom kernel (ret:-2147483647) > No need to update kernel type. > Detected board: samsung,rinato-rev06 > Could not do normal boot. (no DTB found) > : Entering usb mode for SM-R380_EUR_XX (65535).. > > Add a "rev06" suffix to compatible to satisfy the bootloader. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > index 84380fa13e37..f72ba0a1d915 100644 > --- a/arch/arm/boot/dts/exynos3250-rinato.dts > +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > @@ -18,7 +18,8 @@ > > / { > model = "Samsung Rinato board"; > - compatible = "samsung,rinato", "samsung,exynos3250", "samsung,exynos3"; > + compatible = "samsung,rinato", "samsung,rinato-rev06", > + "samsung,exynos3250", "samsung,exynos3"; I think it is wrong. The released bootloader from Samsung is not u-boot. Instead, you have to update u-boot to support Exynos3250-basd Rinato board. Thanks, Chanwoo Choi ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: Fix booting on Rinato market device 2014-11-07 11:50 ` Chanwoo Choi @ 2014-11-07 11:59 ` Krzysztof Kozlowski 2014-11-08 10:16 ` Kukjin Kim 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2014-11-07 11:59 UTC (permalink / raw) To: Chanwoo Choi Cc: Ben Dooks, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, Kyungmin Park, BartlomiejZolnierkiewicz On pią, 2014-11-07 at 20:50 +0900, Chanwoo Choi wrote: > Hi Krzysztof, > > On 11/07/2014 08:44 PM, Krzysztof Kozlowski wrote: > > The bootloader on market Rinato (Gear 2) device checks for revision in > > compatible field of DTB. If it is not present or lower than required > > then booting fails with: "Could not do normal boot. (no DTB found)". > > > > Log of bootloader in case of failure: > > h/w: revision = 0x06 > > h/w: schematic = SM-R380_Rev0.5_Final_0205 > > date = 2000/01/01 12:00:21 (UTC) > > cmu_div:4, div:5, src_clk:800000000, pixel_clk:31860720 > > load_kernel: loading boot image from 57344.. (BOOT) > > load_kernel: found zImage, size: 0x3267e8 > > 0xbc Error! > > Verify_Binary_Signature: failed. > > pit_check_signature (BOOT) invalid. > > load_kernel: found custom kernel (ret:-2147483647) > > No need to update kernel type. > > Detected board: samsung,rinato-rev06 > > Could not do normal boot. (no DTB found) > > : Entering usb mode for SM-R380_EUR_XX (65535).. > > > > Add a "rev06" suffix to compatible to satisfy the bootloader. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > > index 84380fa13e37..f72ba0a1d915 100644 > > --- a/arch/arm/boot/dts/exynos3250-rinato.dts > > +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > > @@ -18,7 +18,8 @@ > > > > / { > > model = "Samsung Rinato board"; > > - compatible = "samsung,rinato", "samsung,exynos3250", "samsung,exynos3"; > > + compatible = "samsung,rinato", "samsung,rinato-rev06", > > + "samsung,exynos3250", "samsung,exynos3"; > > I think it is wrong. The released bootloader from Samsung is not u-boot. > Instead, you have to update u-boot to support Exynos3250-basd Rinato board. The bootloader on device also was not a u-boot. So the fix is for native bootloader delivered on device. I do not insist that this is proper fix. It was just needed to boot the device with custom kernel. Anyway, thanks for comments! Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] ARM: dts: Fix booting on Rinato market device 2014-11-07 11:59 ` Krzysztof Kozlowski @ 2014-11-08 10:16 ` Kukjin Kim 2014-11-10 1:03 ` Chanwoo Choi 0 siblings, 1 reply; 5+ messages in thread From: Kukjin Kim @ 2014-11-08 10:16 UTC (permalink / raw) To: 'Krzysztof Kozlowski', 'Chanwoo Choi' Cc: 'Ben Dooks', 'Rob Herring', 'Pawel Moll', 'Mark Rutland', 'Ian Campbell', 'Kumar Gala', 'Russell King', linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, 'Kyungmin Park', 'BartlomiejZolnierkiewicz' Krzysztof Kozlowski wrote: > > On pią, 2014-11-07 at 20:50 +0900, Chanwoo Choi wrote: > > Hi Krzysztof, > > > > On 11/07/2014 08:44 PM, Krzysztof Kozlowski wrote: > > > The bootloader on market Rinato (Gear 2) device checks for revision in > > > compatible field of DTB. If it is not present or lower than required > > > then booting fails with: "Could not do normal boot. (no DTB found)". > > > > > > Log of bootloader in case of failure: > > > h/w: revision = 0x06 > > > h/w: schematic = SM-R380_Rev0.5_Final_0205 > > > date = 2000/01/01 12:00:21 (UTC) > > > cmu_div:4, div:5, src_clk:800000000, pixel_clk:31860720 > > > load_kernel: loading boot image from 57344.. (BOOT) > > > load_kernel: found zImage, size: 0x3267e8 > > > 0xbc Error! > > > Verify_Binary_Signature: failed. > > > pit_check_signature (BOOT) invalid. > > > load_kernel: found custom kernel (ret:-2147483647) > > > No need to update kernel type. > > > Detected board: samsung,rinato-rev06 > > > Could not do normal boot. (no DTB found) > > > : Entering usb mode for SM-R380_EUR_XX (65535).. > > > > > > Add a "rev06" suffix to compatible to satisfy the bootloader. > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > > --- > > > arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > > > index 84380fa13e37..f72ba0a1d915 100644 > > > --- a/arch/arm/boot/dts/exynos3250-rinato.dts > > > +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > > > @@ -18,7 +18,8 @@ > > > > > > / { > > > model = "Samsung Rinato board"; > > > - compatible = "samsung,rinato", "samsung,exynos3250", "samsung,exynos3"; > > > + compatible = "samsung,rinato", "samsung,rinato-rev06", > > > + "samsung,exynos3250", "samsung,exynos3"; > > > > I think it is wrong. The released bootloader from Samsung is not u-boot. > > Instead, you have to update u-boot to support Exynos3250-basd Rinato board. > > The bootloader on device also was not a u-boot. So the fix is for native > bootloader delivered on device. > > I do not insist that this is proper fix. It was just needed to boot the > device with custom kernel. > > Anyway, thanks for comments! > Hi Krzysztof and Chanwoo, So, we don’t need this to fix the problem Krzysztof said? OK. - Kukjin ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: Fix booting on Rinato market device 2014-11-08 10:16 ` Kukjin Kim @ 2014-11-10 1:03 ` Chanwoo Choi 0 siblings, 0 replies; 5+ messages in thread From: Chanwoo Choi @ 2014-11-10 1:03 UTC (permalink / raw) To: Kukjin Kim Cc: 'Krzysztof Kozlowski', 'Ben Dooks', 'Rob Herring', 'Pawel Moll', 'Mark Rutland', 'Ian Campbell', 'Kumar Gala', 'Russell King', linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, 'Kyungmin Park', 'BartlomiejZolnierkiewicz' Dear Kukjin, On 11/08/2014 07:16 PM, Kukjin Kim wrote: > Krzysztof Kozlowski wrote: >> >> On pią, 2014-11-07 at 20:50 +0900, Chanwoo Choi wrote: >>> Hi Krzysztof, >>> >>> On 11/07/2014 08:44 PM, Krzysztof Kozlowski wrote: >>>> The bootloader on market Rinato (Gear 2) device checks for revision in >>>> compatible field of DTB. If it is not present or lower than required >>>> then booting fails with: "Could not do normal boot. (no DTB found)". >>>> >>>> Log of bootloader in case of failure: >>>> h/w: revision = 0x06 >>>> h/w: schematic = SM-R380_Rev0.5_Final_0205 >>>> date = 2000/01/01 12:00:21 (UTC) >>>> cmu_div:4, div:5, src_clk:800000000, pixel_clk:31860720 >>>> load_kernel: loading boot image from 57344.. (BOOT) >>>> load_kernel: found zImage, size: 0x3267e8 >>>> 0xbc Error! >>>> Verify_Binary_Signature: failed. >>>> pit_check_signature (BOOT) invalid. >>>> load_kernel: found custom kernel (ret:-2147483647) >>>> No need to update kernel type. >>>> Detected board: samsung,rinato-rev06 >>>> Could not do normal boot. (no DTB found) >>>> : Entering usb mode for SM-R380_EUR_XX (65535).. >>>> >>>> Add a "rev06" suffix to compatible to satisfy the bootloader. >>>> >>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>>> --- >>>> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts >>>> index 84380fa13e37..f72ba0a1d915 100644 >>>> --- a/arch/arm/boot/dts/exynos3250-rinato.dts >>>> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts >>>> @@ -18,7 +18,8 @@ >>>> >>>> / { >>>> model = "Samsung Rinato board"; >>>> - compatible = "samsung,rinato", "samsung,exynos3250", "samsung,exynos3"; >>>> + compatible = "samsung,rinato", "samsung,rinato-rev06", >>>> + "samsung,exynos3250", "samsung,exynos3"; >>> >>> I think it is wrong. The released bootloader from Samsung is not u-boot. >>> Instead, you have to update u-boot to support Exynos3250-basd Rinato board. >> >> The bootloader on device also was not a u-boot. So the fix is for native >> bootloader delivered on device. >> >> I do not insist that this is proper fix. It was just needed to boot the >> device with custom kernel. >> >> Anyway, thanks for comments! >> > Hi Krzysztof and Chanwoo, > > So, we don’t need this to fix the problem Krzysztof said? OK. Yes. The released bootloader from Samsung is not general and not opened. We have to support Exynos3250-based Rinato on general bootloader. Beset Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-10 1:03 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-07 11:44 [PATCH] ARM: dts: Fix booting on Rinato market device Krzysztof Kozlowski 2014-11-07 11:50 ` Chanwoo Choi 2014-11-07 11:59 ` Krzysztof Kozlowski 2014-11-08 10:16 ` Kukjin Kim 2014-11-10 1:03 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox