From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754913AbcIFFTv convert rfc822-to-8bit (ORCPT ); Tue, 6 Sep 2016 01:19:51 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:58636 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752848AbcIFFTt (ORCPT ); Tue, 6 Sep 2016 01:19:49 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="10646014" From: Zhao Lei To: "'Sean Fu'" , CC: , , , , References: <1473133858-12230-1-git-send-email-fxinrong@gmail.com> In-Reply-To: <1473133858-12230-1-git-send-email-fxinrong@gmail.com> Subject: RE: [PATCH v2] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree. Date: Tue, 6 Sep 2016 13:19:39 +0800 Message-ID: <005301d207fe$447ebd50$cd7c37f0$@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQE3+kvumImESGuVRQNfk9cgssiVOaGgBtEA Content-Language: zh-cn X-yoursite-MailScanner-ID: 330E54026D02.A8D50 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: zhaolei@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Sean Fu > -----Original Message----- > From: Sean Fu [mailto:fxinrong@gmail.com] > Sent: Tuesday, September 06, 2016 11:51 AM > To: dsterba@suse.com > Cc: clm@fb.com; anand.jain@oracle.com; fdmanana@suse.com; > zhaolei@cn.fujitsu.com; linux-kernel@vger.kernel.org; > linux-btrfs@vger.kernel.org; Sean Fu > Subject: [PATCH v2] Btrfs: remove unnecessary code of chunk_root assignment > in btrfs_read_chunk_tree. > > The input argument root is already set with "fs_info->chunk_root". > "chunk_root = fs_info->chunk_root = btrfs_alloc_root(fs_info)" in caller > "open_ctree". > "root->fs_info = fs_info” in "btrfs_alloc_root". > > Signed-off-by: Sean Fu > --- > Changes in v2: > - Renaming root to chunk_root to make it clear. > > fs/btrfs/volumes.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c > index 366b335..eb3d04a 100644 > --- a/fs/btrfs/volumes.c > +++ b/fs/btrfs/volumes.c > @@ -6591,7 +6591,7 @@ out_short_read: > return -EIO; > } > > -int btrfs_read_chunk_tree(struct btrfs_root *root) > +int btrfs_read_chunk_tree(struct btrfs_root *chunk_root) Maybe you also need to modify function body to make it pass compile, and the header file also need to be modified. BTW, Qu Wenruo give us a better way in reply, we can use fs_info directly. Thanks Zhaolei > { > struct btrfs_path *path; > struct extent_buffer *leaf; > @@ -6600,8 +6600,6 @@ int btrfs_read_chunk_tree(struct btrfs_root *root) > int ret; > int slot; > > - root = root->fs_info->chunk_root; > - > path = btrfs_alloc_path(); > if (!path) > return -ENOMEM; > -- > 2.6.2 >