From: "Kwanghoon Son" <k.son@samsung.com>
To: "'Conor Dooley'" <conor@kernel.org>
Cc: <p.zabel@pengutronix.de>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<jszhang@kernel.org>, <guoren@kernel.org>, <wefu@redhat.com>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <inki.dae@samsung.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: RE: [PATCH v3 1/3] dt-bindings: reset: Document th1520 reset control
Date: Tue, 19 Sep 2023 14:08:32 +0900 [thread overview]
Message-ID: <005301d9eab7$5688c920$039a5b60$@samsung.com> (raw)
In-Reply-To:
> > > + - const: thead,th1520-reset
> > > + - const: syscon
> >
> > iDumb question perhaps, but why is this a syscon?
>
> This is good point.
> In fact, I took it from the vendor kernel, and I tried to keep it as same as I could.
> Vendor also followed drivers/reset/reset-imx7.c
> As Rob said, if don't need it, I'll change it.
>
> Regards,
> Kwang.
>
I have investigated vendor kernels, but it is still not sure reset information.
I thought this is about sys_reg, but without datasheet, can't tell.
Therefore, should be stopped patch for a while until knows better comes out.
Kwang.
> > Cheers,
> > Conor.
> >
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + '#reset-cells':
> > > + const: 1
next prev parent reply other threads:[~2023-09-19 5:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230918045133epcas1p42fa41cb80a1250b9db28f398b31d041c@epcas1p4.samsung.com>
2023-09-18 4:51 ` [PATCH v3 0/3] Introduce reset driver for T-HEAD th1520 SoC Kwanghoon Son
2023-09-18 4:51 ` [PATCH v3 1/3] dt-bindings: reset: Document th1520 reset control Kwanghoon Son
2023-09-18 21:26 ` Conor Dooley
2023-09-19 1:45 ` Kwanghoon Son
2023-09-19 5:08 ` Kwanghoon Son [this message]
2023-09-19 8:47 ` Conor Dooley
2023-09-19 9:14 ` Guo Ren
2023-11-29 16:42 ` Xi Ruoyao
2023-11-30 15:37 ` Conor Dooley
2023-09-18 21:33 ` Rob Herring
2023-09-18 4:51 ` [PATCH v3 2/3] reset: Add th1520 reset driver support Kwanghoon Son
2023-09-18 4:51 ` [PATCH v3 3/3] riscv: dts: Add th1520 reset device tree Kwanghoon Son
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005301d9eab7$5688c920$039a5b60$@samsung.com' \
--to=k.son@samsung.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=inki.dae@samsung.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox