From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A68D24887E for ; Thu, 18 Sep 2025 14:20:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758205239; cv=none; b=SOPu2jxi/Ie2/ycREZm4sWgQL7UB2mnbNBoWjYvZ7linBV6QOh5cLMU+Mx3SwAaOymBOX9ZLPFNw+WwMAfxrN4MbspbMltziwhNz4kiSRHgE6ULd4lRokKD/ECxpTCiLEYrtcyQZaCJsLgeTiWTEqqaobEqudjJEAfQJovdpqPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758205239; c=relaxed/simple; bh=aLT8EU4W6ZT2ILFHMoAHb95Gaq0GYb01rVMThh8lhs0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U+dXZBkLcV2pj9wTCqI6QYUnHcCeSvKx1s5Q5INVurc0MOViMmf3SHet6PMBWLgcygfYQ9jeMIWrASiPbVbgrcAaBmqmDyRXbnaTibCVMlAzSGxjUSW2x2t6amHAuzHicskCRPo3jG2hMpZ9VoKyrEV9VyyQFqnpGlhzGJEzVbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=V+vDhMpn; arc=none smtp.client-ip=209.85.166.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="V+vDhMpn" Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-42480cb4127so1491695ab.1 for ; Thu, 18 Sep 2025 07:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1758205237; x=1758810037; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CGUyDQ28gbrezc/y2GGrwAvmT1nNgBRAv5nk0GUCrzs=; b=V+vDhMpnXJNVVf26RHVVrKscFcj47AuuA7K4ZlqmdyyMpTKkLFdvCJ7hzumlVR7waf vCwUbIq/Xz3SuA6YGfBZVpe+FNwYkg46S1clYwQ9KoNXwt2TfBqC3jArMRVG6m1mFEv5 9miGwz1A1xNdITGPSTzTfkQLxcjuJ380HbK1XP1Q9UTmtK/C9h+A0Dbfr6bu0Z+QEzp2 2rb2sC17TTS2Mct6J79kt/KiwEOzZkM4NBMS6v8iRf7Et4fdaqQPkZ09c5xexzDohjKq eoGxe0YgEkcFIKKaYh5PdoblpopoCKkGgLCK+1v6vpK38gArZ3vaNxBnfVXoXTa+qL0R uD6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758205237; x=1758810037; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CGUyDQ28gbrezc/y2GGrwAvmT1nNgBRAv5nk0GUCrzs=; b=MzElxYpJwlfoiZmzAbbtBj21yQYaU4zAhcug2S96hRZ5M6l6CPSwGiWxdDLWjuZ03h 7cpSIetDkPnco5H+y02jjwxE5LdEXCLj+8oBDBlM8pZFyh3+Si/WtgF3lszm6yqgEFXB jrl+0M+KDPxEq96FRJdEx0gfKO5J8a0EQQpgxH6GC1pHud64zEeh9vnusrgZsshJFwC6 mUcDYuDlQUD3SEHX5WBmugE9S9arJ0vuLktqcWjD4g2R671xhvBNBmSy3zz0WNTuIhnE CWWh9F57saRF7b+YhY/USJhwWOtsnn0b9BSnbym8uMWuJn09ITkelmuC8Z+kWfOKHrTg z2RA== X-Forwarded-Encrypted: i=1; AJvYcCVHrIHVcM1LIaCMZK2eaElALt89Fwe/8SD67Du95O0CACKTJnYAqTnpTRXUvI27fKEt4uampPocxCit36M=@vger.kernel.org X-Gm-Message-State: AOJu0Yyme4pcWBSZDFzkGFkYsJFB0RFl/1+t2IRoEEFwRApXjIw9oem8 Ty6uZiWqcmG9KoSmUFPk+W4ZL9d4OfYZlcH/pwoS4ea6W3DwIwzffXHTYk+irZCBbNI= X-Gm-Gg: ASbGncvMut9D1NvUclEsuKJsahKA/wuRIMIZYTjGxPADzh80isiKkdBIdfnSTkCFSId YgSuB9W2zccKtFo45kv/ur6OKLTM+nQGZsvNyyAlrc6PQOXQKGWrQc44Yt3y/SywnV8Yh/ppR7u tdeOOI1/AMtySUK1j3evTnFjW9AeQoKLqvCmkne8v9rReND0+perBfPxmgwMcWbU8QGf3zz/cKs R2azJIo/sTeTV1Ro9Q3HVu8l0sPK3v6bO1jA/Xhvpmvt6ps207aN6Z3yUbO1gRH3EOcxaC33pXb KmNcKQNmXcrRh42G+kPE+WSqSbL8fnqaXvWYraV8KOcdKzHh9Ii1C3DOrQakxVEob2GVdY/PNOW 4njc+EsRFBmoddZ1fm9/BbFGrHvgWvKeUmQjxTq2lO3FiMwwH6LLAsBRKX0tm+0jgNttYBdlOzs R/Bc3/nA== X-Google-Smtp-Source: AGHT+IFYve4EQ3dvEX4MzZuxtP/eJg9hkH/7xZ8/C/iLPdxKPkoWIGurBe2rCvRfKygvBsgv23fk9g== X-Received: by 2002:a92:cda2:0:b0:424:6c1:a778 with SMTP id e9e14a558f8ab-4241a52851fmr78183445ab.20.1758205237057; Thu, 18 Sep 2025 07:20:37 -0700 (PDT) Received: from [172.22.22.234] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-4244afaa351sm10679535ab.29.2025.09.18.07.20.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Sep 2025 07:20:35 -0700 (PDT) Message-ID: <0053c0ca-340f-46fd-adb1-6af6928717ee@riscstar.com> Date: Thu, 18 Sep 2025 09:20:34 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] riscv: dts: spacemit: define a SPI controller node To: Yixun Lan Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250917220724.288127-1-elder@riscstar.com> <20250917220724.288127-4-elder@riscstar.com> <20250918133209-GYB1273705@gentoo.org> <5956e320-7cbb-4d9a-95a7-720cfa6b9654@riscstar.com> <20250918140633-GYA1274501@gentoo.org> Content-Language: en-US From: Alex Elder In-Reply-To: <20250918140633-GYA1274501@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/18/25 9:06 AM, Yixun Lan wrote: > Hi Alex, > > On 08:51 Thu 18 Sep , Alex Elder wrote: >> On 9/18/25 8:32 AM, Yixun Lan wrote: >>>> + spi3: spi@d401c000 { >>>> + compatible = "spacemit,k1-spi"; >>>> + reg = <0x0 0xd401c000 0x0 0x30>; >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + clocks = <&syscon_apbc CLK_SSP3>, >>>> + <&syscon_apbc CLK_SSP3_BUS>; >>> .. >>>> + clock-names = "core", >>>> + "bus"; >>> can you simply put them together in one line? it's kind of tedious to split.. >> >> Sure I can do that. I've seen it both ways. >> > right, it's merely a coding style I want to enforce, to make it slightly consistent > >>>> + resets = <&syscon_apbc RESET_SSP3>; >>>> + interrupts-extended = <&plic 55>; >>> why use interrupts-extended? >> >> Because it specifies both the controller and interrupt number >> explicitly. Why *not* use interrupts-extended? >> > It's just unnecessary, the SPI node will fall back to find parent node's interrupt > which already specific as &plic, brings no benefits The benefit it brings is that I don't have to search backward to see what the interrupt controller is. I realize it's redundant but I do prefer interrupts-extended over just interrupts. -Alex > >>>> + spacemit,k1-ssp-id = <3>; >>>> + dmas = <&pdma 20>, >>>> + <&pdma 19>; >