From: "Bharat Uppal" <bharat.uppal@samsung.com>
To: "'Bart Van Assche'" <bvanassche@acm.org>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<James.Bottomley@HansenPartnership.com>,
<martin.petersen@oracle.com>, <alim.akhtar@samsung.com>,
<avri.altman@wdc.com>, <linux-samsung-soc@vger.kernel.org>
Cc: <pankaj.dubey@samsung.com>, <aswani.reddy@samsung.com>,
"'Nimesh Sati'" <nimesh.sati@samsung.com>,
<bharat.uppal@samsung.com>
Subject: RE: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend
Date: Thu, 28 Aug 2025 15:46:24 +0530 [thread overview]
Message-ID: <005401dc1804$d68d9110$83a8b330$@samsung.com> (raw)
In-Reply-To:
Hi Bart,
I have made the relevant changes and pushed the updated patch.
Can you please review it and close the same.
With Regards
Bharat Uppal
> -----Original Message-----
> From: Bharat Uppal <bharat.uppal@samsung.com>
> Sent: 05 August 2025 10:58
> To: 'Bart Van Assche' <bvanassche@acm.org>; 'linux-scsi@vger.kernel.org'
> <linux-scsi@vger.kernel.org>; 'linux-kernel@vger.kernel.org' <linux-
> kernel@vger.kernel.org>; 'James.Bottomley@HansenPartnership.com'
> <James.Bottomley@HansenPartnership.com>;
> 'martin.petersen@oracle.com' <martin.petersen@oracle.com>;
> 'alim.akhtar@samsung.com' <alim.akhtar@samsung.com>;
> 'avri.altman@wdc.com' <avri.altman@wdc.com>; 'linux-samsung-
> soc@vger.kernel.org' <linux-samsung-soc@vger.kernel.org>
> Cc: 'pankaj.dubey@samsung.com' <pankaj.dubey@samsung.com>;
> 'aswani.reddy@samsung.com' <aswani.reddy@samsung.com>; 'Nimesh Sati'
> <nimesh.sati@samsung.com>
> Subject: RE: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in
> reset on suspend
>
>
> > -----Original Message-----
> > From: Bart Van Assche <bvanassche@acm.org>
> > Sent: 04 August 2025 21:17
> > To: Bharat Uppal <bharat.uppal@samsung.com>;
> > linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
> > James.Bottomley@HansenPartnership.com;
> > martin.petersen@oracle.com; alim.akhtar@samsung.com;
> > avri.altman@wdc.com; linux-samsung-soc@vger.kernel.org
> > Cc: pankaj.dubey@samsung.com; aswani.reddy@samsung.com; Nimesh
> Sati
> > <nimesh.sati@samsung.com>
> > Subject: Re: [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS
> > device in reset on suspend
> >
> > On 8/4/25 4:36 AM, Bharat Uppal wrote:
> > > +static int fsd_ufs_suspend(struct exynos_ufs *ufs) {
> > > + exynos_ufs_gate_clks(ufs);
> > > + hci_writel(ufs, 0 << 0, HCI_GPIO_OUT);
> > > + return 0;
> > > +}
> >
> > Why '0 << 0' instead of just '0'? Isn't the latter easier to read?
> Thanks for reviewing.
> Indeed setting 0 is right, but in the same file ufs-exynos.c, I have seen
> HCI_GPIO_OUT register configured using 0 << 0.
> My intent here is to maintain coding style within the file.
>
> With Regards
> Bharat Uppal
>
> >
> > Thanks,
> >
> > Bart.
next prev parent reply other threads:[~2025-08-28 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250804113654epcas5p1dc2a495e16ff0f66eafc54be67550f23@epcas5p1.samsung.com>
2025-08-04 11:36 ` [PATCH] scsi: ufs: exynos: fsd: Gate ref_clk and put UFS device in reset on suspend Bharat Uppal
2025-08-04 15:46 ` Bart Van Assche
2025-08-05 5:28 ` Bharat Uppal
2025-08-28 10:16 ` Bharat Uppal [this message]
[not found] <CGME20250821053938epcas5p290f78790250d8cb09df2f35e45624359@epcas5p2.samsung.com>
2025-08-21 5:39 ` Bharat Uppal
2025-08-28 13:35 ` Bart Van Assche
2025-08-31 1:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005401dc1804$d68d9110$83a8b330$@samsung.com' \
--to=bharat.uppal@samsung.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nimesh.sati@samsung.com \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).