* [PATCH] elevator: remove unneeded kfree in error path of elevator_alloc
@ 2015-04-23 7:44 Chao Yu
2015-04-23 14:58 ` Jeff Moyer
0 siblings, 1 reply; 2+ messages in thread
From: Chao Yu @ 2015-04-23 7:44 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel
In elevator_alloc, if we fail to allocate memory for storing elevator
queue, our eq pointer must be NULL, we do not need to release it in error
path, so remove it.
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
---
block/elevator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/elevator.c b/block/elevator.c
index 59794d0..d146a5e 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -166,7 +166,6 @@ struct elevator_queue *elevator_alloc(struct request_queue *q,
return eq;
err:
- kfree(eq);
elevator_put(e);
return NULL;
}
--
2.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] elevator: remove unneeded kfree in error path of elevator_alloc
2015-04-23 7:44 [PATCH] elevator: remove unneeded kfree in error path of elevator_alloc Chao Yu
@ 2015-04-23 14:58 ` Jeff Moyer
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Moyer @ 2015-04-23 14:58 UTC (permalink / raw)
To: Chao Yu; +Cc: axboe, linux-kernel
Chao Yu <chao2.yu@samsung.com> writes:
> In elevator_alloc, if we fail to allocate memory for storing elevator
> queue, our eq pointer must be NULL, we do not need to release it in error
> path, so remove it.
>
> Signed-off-by: Chao Yu <chao2.yu@samsung.com>
> ---
> block/elevator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/elevator.c b/block/elevator.c
> index 59794d0..d146a5e 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -166,7 +166,6 @@ struct elevator_queue *elevator_alloc(struct request_queue *q,
>
> return eq;
> err:
> - kfree(eq);
> elevator_put(e);
> return NULL;
> }
Acked-by: Jeff Moyer <jmoyer@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-23 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-23 7:44 [PATCH] elevator: remove unneeded kfree in error path of elevator_alloc Chao Yu
2015-04-23 14:58 ` Jeff Moyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox