From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75ADA4A3412 for ; Wed, 6 May 2026 18:19:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091587; cv=none; b=q3wleWdMiFo9zeOMLwHkm9XXOHs3yzaqbV/OeazFBFrL5HvWSVsmRuDpc4wWg5KTC37GIvJGDko11KL2UrElMoG+uwOnk6nZbpoKGwv9WFEsP2wUGDNMd1Gpb5VoEmjTHBxP5smVslLlHSkJhGFqHQ/eYslXSI/+i+X+xAQaPQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091587; c=relaxed/simple; bh=7aiu2JUFoolSsX24+en1TLO4jHhLy4ztH/j+S3dnKmU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=KV8H9ZHXbPtydR4vEZ8FxzgCRDvcnITaLlphDe4G8hPTiSx/F5x2yUnVDpLvsFufQr0Ux356e1jWA00PxouCPnWom5VhU7PmpWABi+SnOBNq/76Z8Of4YZeeH/6PtJLHf6dH6V8pxJxbceV7PqAtLXlbx07gtgz2TJMT4GGzeko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Brj8A/Zb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KqSeVHBs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Brj8A/Zb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KqSeVHBs" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 646C5Kvr3036455 for ; Wed, 6 May 2026 18:19:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fW7+cAaB9tFYadSH4iU2QxnEOPZYkbnvDwiqGGx9hdw=; b=Brj8A/Zb65emycac 3xJRMK4BCeAN+LdEAaWbPQMYPEBe5q8uyeizOGzX6DRYj4OHH8BiNdJ63U0NDtTx /oFQzG5Y2gm+cdTRQ6gb16EuD2zyg67CAraf1umrds9vnhLY8DwvOLAoeMQf/sj8 QBdnnN+WLmIlan7uJurTmsrAhiXLx544xLzVXBcZy+NYSe1SYKAOxCwXChQT3uJS JinWIQAz2m5cELZZkxA8n41TdSAKjv60TyM4XvTcX7WKppmNWY1QKFZENrYl+5CH 9RJafTx3bwp4UQNy1ujM256AZz3O+vVQsMnQTwmJDHiOH04FdQRhwjmXwyyyz67W Feuucg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e05bf1e6k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 18:19:45 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8354503d9acso4411363b3a.1 for ; Wed, 06 May 2026 11:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778091584; x=1778696384; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=fW7+cAaB9tFYadSH4iU2QxnEOPZYkbnvDwiqGGx9hdw=; b=KqSeVHBsijfBsWIKu7/rieMJBPMeHnmA9GcYPzvwAOY3htFjq+LFmRQCBrqNQNOnS7 66b2rRmGlZSgHRhGSKyEFJvkTFLZkaXl1ndweVV+qGxEmAeXsrJr1X+FgrOeBt68KMYW vd5m/VD2hzq/hl8shrcEb/XjcggNfGopgV430WXe9jzt6ZFn07Z7RvMpBOG4sczCltj7 yYy8AbBcxoPeihVoNZsPYlmZ+Yj1eyQvKw11+mMx21AU2wrabxqstWCCj0ktrePsBwcB MyA1c/tV1GfTCPXHDlF6b0GcBRn5bL+OrW6pWZo1xXT2jKQXNtAbj9L283AGdiJWnjmj 2TXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778091584; x=1778696384; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fW7+cAaB9tFYadSH4iU2QxnEOPZYkbnvDwiqGGx9hdw=; b=ZNmyVH/OZx/0Xf1S+heRgMk+4V1Uruc76ruJLUpnUwmFltwbLZy0G+ndpbozZK5ErO 5bId2r/J0xCk2W6s0wvndqVxRGN5TJr2l5GIYP1E9u6ErBYt0D2AT53J81S9arkaMivL Qf5RscDfHLudGggwTvsdjtzuKmuET0Q7frVKqbQVlxn/vKPRpeAOWMTMpNLAcujvxmLT HuJGJXqSMXcX5AjN9enL+wSX7THNbGkG2XLEPvvY4ksRyCuBbIGSq4sYi6evd3k1A37G wjsbAL8V/DLOrItByvgaV/hmTk8OMT2ytY3z0gKELitL7qicLEEGGqSM93PcvmD4wHKJ fFCQ== X-Forwarded-Encrypted: i=1; AFNElJ8FTJNQMo5wkWHqimIXT78KSaGsnTcyDCCCumognz7rNY10UzY33pDZOQQEZiAL3ftFq3+4eGzcziMogws=@vger.kernel.org X-Gm-Message-State: AOJu0YzIskkkdg2HIQpeRwr3igV9J2/92wOY3/XqEWh1IBm/b9AnWPFz Rz5pC2rl7ZbOHPcuVmZ5qDVssayRzHP/+NlTXZcI2Ipbhqyt+Ofw6YY7AlxK2oVjzI9/uvzjMEF JjnOpGmfcPgtc2EAYVnI7YILkPPRnPGHXZ0I35QvsZIibPsMiKhdeGsGFQE1NxOfJytXDSJYuRQ A= X-Gm-Gg: AeBDiev12Y5diW15OB1/Vrblkt8U+nHRJL8Cy6MQwUEB0SGB0sVOJykhroOH9ePQ0zY 54LBdCUnlkYTogtnV+Rt0F3zKyGM8DSI47YRenCWYuq/weL18QLFaJi46HXbMUqVcuM1aZ492Od /w0HdJHx+AfmN4WQDqJH1c9XC9SQTfnpmGYIHTW8nnPmA0CM6eCZUoHOYUFlyjkVUj7ON9qcd8O 3+5VkfFIMSsk//LjerzN81lKheRDuL7tmnDnNkFljP9gosYRMEfdj0S+LYuhvJHtW58YpcXKzuT plUhCuLR2qlUSRHwGvfixKN7DOUHWf4tJEm2kl/yExyYDP3x7Zf1/cSWUGzoXN76Rk2WxwFfxmd 48hzeTFb/n1Uh665mQbZDciOgzPy0NoPdtsaPWuCY7npzZtet/1opdNrWpoVUXESpTWJEBmiJkc C7 X-Received: by 2002:a05:6a00:4517:b0:827:3d52:5d1a with SMTP id d2e1a72fcca58-83a58a2afc1mr3812507b3a.0.1778091583965; Wed, 06 May 2026 11:19:43 -0700 (PDT) X-Received: by 2002:a05:6a00:4517:b0:827:3d52:5d1a with SMTP id d2e1a72fcca58-83a58a2afc1mr3812477b3a.0.1778091583464; Wed, 06 May 2026 11:19:43 -0700 (PDT) Received: from [192.168.11.104] ([124.123.82.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839659487afsm5831890b3a.18.2026.05.06.11.19.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 11:19:43 -0700 (PDT) Message-ID: <005af843-da19-4df9-af67-2cd148b24d62@oss.qualcomm.com> Date: Wed, 6 May 2026 23:49:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Rameshkumar Sundaram Subject: Re: [PATCH] wifi: ath11k: fix warning when unbinding To: Jose Ignacio Tornos Martinez , jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260420110130.509670-1-jtornosm@redhat.com> Content-Language: en-US In-Reply-To: <20260420110130.509670-1-jtornosm@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDE3OSBTYWx0ZWRfX51nBPwrzXQ9G /Q6tyaDK7rIMy6EOEVoPLn6Txv6LaGYMkBH3OXe7B8uM/KsVyyLMxIGPWjanLpeXyVNbnDe+t1X PddOF7pmwmfFZr50idWYtKuijNS+Beuk1uAwoda/H63TyZh+IEiEcLVmJ2Oj4/CfttwY+RUOj/q +edzUhudeDooEWnEfiPGz3CmKCq0ME83man2Z3gWjpdd68rad57MECG27XpovPedKRduz/b2PzF 2IiWWSlarEKy1zEGhhIkAJa+3RZVxpeFfPgC6iruxup+0K7RNScQ8ibwubAYmE3tk1arv/6OM3G 9oj7e5zwfvsjJQ/sxqG837+6pprLgU29xvCT6nUvsIgumV4fNfQwvoI5e7UdWaj8CkhRuMJWpl/ mqx/m9VPZyD/I65y7+jDyeypg4BwQwSy+g9p0UYOGplDcntFZpNRdXVn59rhZFu+qEfk477lRT6 8genrsWsCyeoQJZxgsg== X-Authority-Analysis: v=2.4 cv=PqmjqQM3 c=1 sm=1 tr=0 ts=69fb8641 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZCREz13nqshT/on6E9YcPw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=20KFwNOVAAAA:8 a=vrVOvOPcliifg5cE6R0A:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: _Muqs_y8-BG4rYifAxwLSe9G2eKHJ2u1 X-Proofpoint-ORIG-GUID: _Muqs_y8-BG4rYifAxwLSe9G2eKHJ2u1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060179 On 4/20/2026 4:31 PM, Jose Ignacio Tornos Martinez wrote: > If there is an error during some initialization related to firmware, > the buffers dp->tx_ring[i].tx_status are released. > However this is released again when the device is unbinded (ath11k_pci), > and we get: > WARNING: CPU: 0 PID: 6231 at mm/slub.c:4368 free_large_kmalloc+0x57/0x90 > Call Trace: > free_large_kmalloc > ath11k_dp_free > ath11k_core_deinit > ath11k_pci_remove > ... > > The issue is always reproducible from a VM because the MSI addressing > initialization is failing. > > In order to fix the issue, just set the buffers to NULL after releasing in > order to avoid the double free. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Cc: stable@vger.kernel.org > Signed-off-by: Jose Ignacio Tornos Martinez > --- > drivers/net/wireless/ath/ath11k/dp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c > index bbb86f165141..5a50b623bd07 100644 > --- a/drivers/net/wireless/ath/ath11k/dp.c > +++ b/drivers/net/wireless/ath/ath11k/dp.c > @@ -1040,6 +1040,7 @@ void ath11k_dp_free(struct ath11k_base *ab) > idr_destroy(&dp->tx_ring[i].txbuf_idr); > spin_unlock_bh(&dp->tx_ring[i].tx_idr_lock); > kfree(dp->tx_ring[i].tx_status); > + dp->tx_ring[i].tx_status = NULL; > } > > /* Deinit any SOC level resource */ On which hardware did you observe this issue? is it QCA6390, WCN6855, QCA2066 or QCA6698AQ ? Also, where do you see the initial failure ? Is it somewhere in ath11k_core_qmi_firmware_ready() ? I am asking because this looks like it may be exposed by commit 6fe62a8cec51 ("wifi: ath11k: Add cold boot calibration support on WCN6750") [1]. That commit added the ATH11K_QMI_EVENT_FW_READY path, but the return value from ath11k_core_qmi_firmware_ready() is not handled there. If that call fails after ath11k_dp_free() has already run on the error path, ATH11K_FLAG_QMI_FAIL is not set. Later, ath11k_pci_remove() does not take the QMI-fail cleanup path and calls ath11k_core_deinit(), which calls ath11k_dp_free() and other cleanup functions again. This is similar to the failure case fixed earlier by a19c0e104db9 ("ath11k: Handle failure in qmi firmware ready") [2], where failure from ath11k_core_qmi_firmware_ready() needed to be handled. [1] https://lore.kernel.org/r/20220720134909.15626-3-quic_mpubbise@quicinc.com [2] https://lore.kernel.org/r/1645079195-13564-1-git-send-email-quic_seevalam@quicinc.com -- Ramesh