From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965034Ab2JDBP4 (ORCPT ); Wed, 3 Oct 2012 21:15:56 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:32435 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964906Ab2JDBPz (ORCPT ); Wed, 3 Oct 2012 21:15:55 -0400 X-AuditID: cbfee61b-b7f2b6d000000f14-06-506ce349edce From: Jingoo Han To: "'Thierry Reding'" , linux-kernel@vger.kernel.org Cc: "'Shawn Guo'" , "'Mark Brown'" , "'Arnd Bergmann'" , "'Sachin Kamat'" , "'Axel Lin'" , "'Kukjin Kim'" , "'Jonghwan Choi'" , "'Sascha Hauer'" , "'Philip, Avinash'" , "'Vaibhav Bedia'" , "'Jingoo Han'" References: <1349073294-14947-1-git-send-email-thierry.reding@avionic-design.de> In-reply-to: <1349073294-14947-1-git-send-email-thierry.reding@avionic-design.de> Subject: Re: [PATCH] pwm: Check for negative duty-cycle and period Date: Thu, 04 Oct 2012 10:15:52 +0900 Message-id: <005c01cda1cd$cc202a00$64607e00$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac2fnu38uagSqHmhRX6y26RTUznPEgCLqQgA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsVy+t9jQV3PxzkBBk8PcFlc3jWHzYHR4/Mm uQDGKC6blNSczLLUIn27BK6MfxPushRsVKjYeusVawPjAqkuRk4OCQETieuXe5kgbDGJC/fW s3UxcnEICUxnlFhy4S4LhDObSWLDn19gVWwCahJfvhxmB7FFBMIlNk9YxQxSxCxwjFlixZw+ oAQHUEeAxIGudJAaToFgiePN51lBbGEBJ4kPjUsZQWwWAVWJ5y/esoHYvAK2EjdfbWWBsAUl fky+B2YzC2hJrN95nAnClpfYvOYtM8h4CQF1iUd/dSFOMJI4fHApVLmIxL4X7xgnMArNQjJp FpJJs5BMmoWkZQEjyypG0dSC5ILipPRcI73ixNzi0rx0veT83E2M4EB+Jr2DcVWDxSFGAQ5G JR5ei0k5AUKsiWXFlbmHGCU4mJVEeI23AoV4UxIrq1KL8uOLSnNSiw8xSnOwKInzNnukBAgJ pCeWpGanphakFsFkmTg4pRoYk6SY1uae9urYOs+O/590FmP5yZveT+9HCq8WX//kjnf+2i32 DZMYJUpFzjuKPPEW+PCK/aGgVtXvey12HCF+Qb0bl3J8sFmZarxFYapz0pYM6ZNBcdXno7j/ afOX/Q2aWfWt8fa6/op7J7o5+e5vOClqn1y9xfTwnpyJc06d6blxWoGDfaesEktxRqKhFnNR cSIAU94A3WACAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 01, 2012 3:35 PM Thierry Reding wrote > > Make sure the duty-cycle and period passed in are not negative. This > should eventually be made implicit by making them unsigned. While at > it, the drivers' .config() implementations can have the equivalent > checks removed. > > Signed-off-by: Thierry Reding > Cc: Shawn Guo > Cc: Mark Brown > Cc: Arnd Bergmann > Cc: Sachin Kamat > Cc: Axel Lin > Cc: Kukjin Kim > Cc: Jingoo Han Acked-by: Jingoo Han > Cc: Jonghwan Choi > Cc: Sascha Hauer > Cc: "Philip, Avinash" > Cc: Vaibhav Bedia > --- > drivers/pwm/core.c | 2 +- > drivers/pwm/pwm-bfin.c | 3 --- > drivers/pwm/pwm-pxa.c | 3 --- > drivers/pwm/pwm-samsung.c | 3 --- > drivers/pwm/pwm-tiecap.c | 2 +- > drivers/pwm/pwm-tiehrpwm.c | 2 +- > 6 files changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > index 92b1782..f5acdaa 100644 > --- a/drivers/pwm/core.c > +++ b/drivers/pwm/core.c > @@ -371,7 +371,7 @@ EXPORT_SYMBOL_GPL(pwm_free); > */ > int pwm_config(struct pwm_device *pwm, int duty_ns, int period_ns) > { > - if (!pwm || period_ns == 0 || duty_ns > period_ns) > + if (!pwm || duty_ns < 0 || period_ns <= 0 || duty_ns > period_ns) > return -EINVAL; > > return pwm->chip->ops->config(pwm->chip, pwm, duty_ns, period_ns); > diff --git a/drivers/pwm/pwm-bfin.c b/drivers/pwm/pwm-bfin.c > index d53c4e7..5da8e18 100644 > --- a/drivers/pwm/pwm-bfin.c > +++ b/drivers/pwm/pwm-bfin.c > @@ -69,9 +69,6 @@ static int bfin_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, > unsigned long period, duty; > unsigned long long val; > > - if (duty_ns < 0 || duty_ns > period_ns) > - return -EINVAL; > - > val = (unsigned long long)get_sclk() * period_ns; > do_div(val, NSEC_PER_SEC); > period = val; > diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c > index bd5867a..260c3a8 100644 > --- a/drivers/pwm/pwm-pxa.c > +++ b/drivers/pwm/pwm-pxa.c > @@ -70,9 +70,6 @@ static int pxa_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, > unsigned long offset; > int rc; > > - if (period_ns == 0 || duty_ns > period_ns) > - return -EINVAL; > - > offset = pwm->hwpwm ? 0x10 : 0; > > c = clk_get_rate(pc->clk); > diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c > index e5187c0..023a3be 100644 > --- a/drivers/pwm/pwm-samsung.c > +++ b/drivers/pwm/pwm-samsung.c > @@ -126,9 +126,6 @@ static int s3c_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, > if (period_ns > NS_IN_HZ || duty_ns > NS_IN_HZ) > return -ERANGE; > > - if (duty_ns > period_ns) > - return -EINVAL; > - > if (period_ns == s3c->period_ns && > duty_ns == s3c->duty_ns) > return 0; > diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c > index 081471f..d6d4cf0 100644 > --- a/drivers/pwm/pwm-tiecap.c > +++ b/drivers/pwm/pwm-tiecap.c > @@ -60,7 +60,7 @@ static int ecap_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, > unsigned long period_cycles, duty_cycles; > unsigned int reg_val; > > - if (period_ns < 0 || duty_ns < 0 || period_ns > NSEC_PER_SEC) > + if (period_ns > NSEC_PER_SEC) > return -ERANGE; > > c = pc->clk_rate; > diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c > index caf00fe..d3c1dff 100644 > --- a/drivers/pwm/pwm-tiehrpwm.c > +++ b/drivers/pwm/pwm-tiehrpwm.c > @@ -221,7 +221,7 @@ static int ehrpwm_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, > unsigned short ps_divval, tb_divval; > int i, cmp_reg; > > - if (period_ns < 0 || duty_ns < 0 || period_ns > NSEC_PER_SEC) > + if (period_ns > NSEC_PER_SEC) > return -ERANGE; > > c = pc->clk_rate; > -- > 1.7.12.2