From: Chao Yu <chao2.yu@samsung.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: RE: [f2fs-dev] [PATCH 1/2] f2fs: keep PagePrivate during releasepage
Date: Thu, 05 Feb 2015 15:50:49 +0800 [thread overview]
Message-ID: <005c01d04118$9042c5a0$b0c850e0$@samsung.com> (raw)
In-Reply-To: <1422917479-36393-1-git-send-email-jaegeuk@kernel.org>
> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Tuesday, February 03, 2015 6:51 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 1/2] f2fs: keep PagePrivate during releasepage
>
> If PagePrivate is removed by releasepage, f2fs loses counting dirty pages.
>
> e.g., try_to_release_page will not release page when the page is dirty,
> but our releasepage removes PagePrivate.
>
> [<ffffffff81188d75>] try_to_release_page+0x35/0x50
> [<ffffffff811996f9>] invalidate_inode_pages2_range+0x2f9/0x3b0
> [<ffffffffa02a7f54>] ? truncate_blocks+0x384/0x4d0 [f2fs]
> [<ffffffffa02b7583>] ? f2fs_direct_IO+0x283/0x290 [f2fs]
> [<ffffffffa02b7fb0>] ? get_data_block_fiemap+0x20/0x20 [f2fs]
> [<ffffffff8118aa53>] generic_file_direct_write+0x163/0x170
> [<ffffffff8118ad06>] __generic_file_write_iter+0x2a6/0x350
> [<ffffffff8118adef>] generic_file_write_iter+0x3f/0xb0
> [<ffffffff81203081>] new_sync_write+0x81/0xb0
> [<ffffffff81203837>] vfs_write+0xb7/0x1f0
> [<ffffffff81204459>] SyS_write+0x49/0xb0
> [<ffffffff817c286d>] system_call_fastpath+0x16/0x1b
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
prev parent reply other threads:[~2015-02-05 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 22:51 [PATCH 1/2] f2fs: keep PagePrivate during releasepage Jaegeuk Kim
2015-02-02 22:51 ` [PATCH 2/2] f2fs: show the number of writeback pages in stat Jaegeuk Kim
2015-02-05 7:52 ` [f2fs-dev] " Chao Yu
2015-02-05 7:50 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005c01d04118$9042c5a0$b0c850e0$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox