From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C1533D6465 for ; Thu, 30 Apr 2026 11:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777548446; cv=none; b=aykVqGa48YYdm8mBLEF3AHILGPw/8VY85qRPikisfgmEGvpznDkSzFXPdNCFOR7rdmnIDYZfYE5NzYZ5l5LpJr36czZ7zjkEPmOXT/3r/KrebSeKuxhwAFSI0T3u9v80fUBE3SEKLEOKH2mGmPH1eVa/36Tlb2v3SccNsp77PyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777548446; c=relaxed/simple; bh=2T++ZgnqanVb7btL16I7116C/GmLc7NafiInXl+HwAg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=EBRHWj7Mtoejdg9L+mSJVP9BFpjDhgkwJg1aHcgJraH6f55mkIxXDEYq3blxixbZ0NSMJCdzhOXtsaaUOkt67+MxvvGlTaUDiZrUX7Z02XBR7nFeon10Ocpdqo4eKsjFiAb3csJRGsT85qMVc386A6DiCJQ5tgpi/mBdnPiZ6wI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QimBV/Y6; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ODNclXgI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QimBV/Y6"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ODNclXgI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777548444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CIMy9S5iWlyc40JZ79p231oXUkP2gHnlruiMtNy2qdM=; b=QimBV/Y6IlW8KXhRLpIRQmuf/sU8V6i4BCNEvOBVkzmHXkl7ufXyMtDKGovzq3WqQc0j8l rIr537z8yLGZ7yDB9rM1jyLRx8+yWdZHxUeC7WEW1YF78rkVpMZ6BmD8kNMWJF63kgF8rI xO+bLaBP/0rc/To23nYtCXUAIBUjykQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-uvdaFlpjNNC7o2jzfONI4A-1; Thu, 30 Apr 2026 07:27:22 -0400 X-MC-Unique: uvdaFlpjNNC7o2jzfONI4A-1 X-Mimecast-MFC-AGG-ID: uvdaFlpjNNC7o2jzfONI4A_1777548442 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d03065782so483728f8f.0 for ; Thu, 30 Apr 2026 04:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777548441; x=1778153241; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=CIMy9S5iWlyc40JZ79p231oXUkP2gHnlruiMtNy2qdM=; b=ODNclXgI/vVOyfw+vWdQkOsi4g1BaoPK55kphih59OqU4cnm21p06pmgvfJzG2zBgI gBcNluAdw4lYpNSeIKh6r/MP2pn6jCAeZ0MsuMhVi1olyzRO1ssCH1oTAunkGxzHvbdr Vg/V+BRKlXEIQ2DBrhAOIQzy2UNrJmBWrd/IiozmrD0n79r77nzxUwdHyBp54D7TG360 rvOICVmlGTI3ZqTR1w1s8MAno3RWB7Lby7VqKO3zGdjYf+x9Riss5QLVSIsn6Tj5bYbO BlyzK5sRSKBcxOR6VOGIxr9VpdjC16XDCYMGQloMdc2wCgB4XyOLLSeH3Db4tuT13NSd YItw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777548441; x=1778153241; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CIMy9S5iWlyc40JZ79p231oXUkP2gHnlruiMtNy2qdM=; b=f1elQXjzZsy5sICP/g43TYyah4EGDkrJykB0L3X2qtR1NWnqvor5tQ4bONFIw/WcOj dQ4CCU0Dkg3RsI5v5dIJB755y6JbiO8zk0ChCnJ6HlMQ7UCqCOmYlzS6+12tYC6UPzVE rwWqyO+EQ/LjP+C99bi0cleOYp/6b4zWYRyVK1QwikbmNQLjhlZ1VHpdeObSeEvP147C nzisUDXlncINjqb1ZT659amJJCaNhc2Cda5c1zQ7gROUgIt7zgMKb/9ALRfXiIeqXeOD mIuTM1tLNWAhKUCYuygQS3JCuU/APR7vZdtga9Q5WwKaCdNYFZUylE/ZHXtUv4si01c0 PKnQ== X-Forwarded-Encrypted: i=1; AFNElJ+IqEnMQb64yd9CapHQIK/tCplUWnOPlrOpWQreSFhjkgMpa/Az7/tCpOeCf9tiddG16xxx2ERdwuepUCQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp21hxBl64ZJbxOnIljmJacESeRPb9MMV+H9AnExOCT5cuLe95 zVe+KSGrXDxGI7V+/Eend+YVvz8vjuribuuVEQrP0EeDmUWhJ7nyI8H+RSeBkI/vLoa/F9V0s3d K7K4+au81AiSNP4TcOxAW/ZIf+ep4a3WNuaYeU8kR8v00VHZWpEMgnjQGmVO8v0DYeQ== X-Gm-Gg: AeBDieunvB/NTgR6rGK6rZ7pQliIhHaM0FtPSF8EWHN9nVirMG6LGubi/n28bRPjq5x GZXLdneEHzqaGQG6+LdX+5fFbAj5RnjyY3R0NUGtbl6pIAit+RJpy5YmlzsBbyXdPAKibDl9oPB v3xIPeFbA3vFAgFiPGNYgwVkKAOTCyZztq9NqFZKGHAUVMPmgXOZeaA8bbPCUlElOftLZf+iaWt 0SWNTEjZSyqCs3usgogT4WCaqtKPjOQsYN7y80IDjx3TugmA2WdEYAzYeIWaCeVgRZ65UClRAji HdOv7x2xIU2J9dUtgr7iACHt9UX8NyHkClGRIteQ2Y1yw/eyEpBVL8MqaepirlH/DuD99NGj9s/ BGyndUWTuhJBdse+EReKZVRSRSlIi0EvLqlNkca/WouOmFAnqyihqwIgTbyFcAvYHUA== X-Received: by 2002:a05:6000:3105:b0:43c:fe0e:5bbc with SMTP id ffacd0b85a97d-4493d21f546mr4136260f8f.19.1777548441472; Thu, 30 Apr 2026 04:27:21 -0700 (PDT) X-Received: by 2002:a05:6000:3105:b0:43c:fe0e:5bbc with SMTP id ffacd0b85a97d-4493d21f546mr4136180f8f.19.1777548440919; Thu, 30 Apr 2026 04:27:20 -0700 (PDT) Received: from [192.168.88.32] ([150.228.93.27]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b3d48517sm10934692f8f.5.2026.04.30.04.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 04:27:20 -0700 (PDT) Message-ID: <0060104c-bb38-45d5-8f8e-14708702feac@redhat.com> Date: Thu, 30 Apr 2026 13:27:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: phy: micrel: fix LAN8814 QSGMII soft reset To: Robert Marko , andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, Divya.Koppera@microchip.com, horatiu.vultur@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260428134138.1741253-1-robert.marko@sartura.hr> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260428134138.1741253-1-robert.marko@sartura.hr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/28/26 3:41 PM, Robert Marko wrote: > LAN8814 QSGMII soft reset was moved into the probe function to avoid > triggering it for each of 4 PHY-s in the package. > > However, that broke QSGMII link between the MAC and PHY on most LAN8814 > PHY-s, specificaly for us on the Microchip LAN969x switch. > Reading the QSGMII status registers it was visible that lanes were only > partially synced. > > It looks like the reset timing is crucial, so lets move the reset back > into the .config_init function but guard it with phy_package_init_once() > to avoid it being triggered on each of 4 PHY-s in the package. > Change the probe function to use phy_package_probe_once() for coma and PtP > setup. > > Fixes: 96a9178a29a6 ("net: phy: micrel: lan8814 fix reset of the QSGMII interface") > Signed-off-by: Robert Marko > --- > drivers/net/phy/micrel.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 2aa1dedd21b8..e211a523c258 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -4548,6 +4548,13 @@ static int lan8814_config_init(struct phy_device *phydev) > struct kszphy_priv *lan8814 = phydev->priv; > int ret; > > + if (phy_package_init_once(phydev)) > + /* Reset the PHY */ > + lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS, > + LAN8814_QSGMII_SOFT_RESET, > + LAN8814_QSGMII_SOFT_RESET_BIT, > + LAN8814_QSGMII_SOFT_RESET_BIT) Sashiko says: --- Could this introduce a race condition if multiple ports are brought up concurrently? Because phy_package_init_once() does not provide a synchronization barrier for followers, they might proceed immediately to configure their registers while the leader is still performing the reset. --- on top of my head IDK if such race is possible at all. /P