[PATCH 0258/1285] Replace numeric parameter like 0444 with macro

[PATCH 0258/1285] Replace numeric parameter like 0444 with macro

[Baole Ni]

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/infiniband/hw/cxgb4/qp.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index e8993e4..3b2d95d 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -35,27 +35,27 @@
 #include "iw_cxgb4.h"
 
 static int db_delay_usecs = 1;
-module_param(db_delay_usecs, int, 0644);
+module_param(db_delay_usecs, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(db_delay_usecs, "Usecs to delay awaiting db fifo to drain");
 
 static int ocqp_support = 1;
-module_param(ocqp_support, int, 0644);
+module_param(ocqp_support, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(ocqp_support, "Support on-chip SQs (default=1)");
 
 int db_fc_threshold = 1000;
-module_param(db_fc_threshold, int, 0644);
+module_param(db_fc_threshold, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(db_fc_threshold,
 		 "QP count/threshold that triggers"
 		 " automatic db flow control mode (default = 1000)");
 
 int db_coalescing_threshold;
-module_param(db_coalescing_threshold, int, 0644);
+module_param(db_coalescing_threshold, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(db_coalescing_threshold,
 		 "QP count/threshold that triggers"
 		 " disabling db coalescing (default = 0)");
 
 static int max_fr_immd = T4_MAX_FR_IMMD;
-module_param(max_fr_immd, int, 0644);
+module_param(max_fr_immd, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(max_fr_immd, "fastreg threshold for using DSGL instead of immedate");
 
 static int alloc_ird(struct c4iw_dev *dev, u32 ird)
-- 
2.9.2

RE: [PATCH 0258/1285] Replace numeric parameter like 0444 with macro

[Steve Wise]

Acked-by: Steve Wise <swise@opengridcomputing.com>