From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932163AbbA3FNA (ORCPT ); Fri, 30 Jan 2015 00:13:00 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:28665 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbbA3FM6 (ORCPT ); Fri, 30 Jan 2015 00:12:58 -0500 X-AuditID: cbfee61b-f79d76d0000024d6-38-54cb12d81e68 From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1422401503-4769-1-git-send-email-jaegeuk@kernel.org> <1422401503-4769-4-git-send-email-jaegeuk@kernel.org> <002d01d03bbd$8b533c10$a1f9b430$@samsung.com> <20150129213931.GA17521@jaegeuk-mac02> In-reply-to: <20150129213931.GA17521@jaegeuk-mac02> Subject: RE: [PATCH 4/5] f2fs: should fail mount when trying to recover data on read-only dev Date: Fri, 30 Jan 2015 13:12:10 +0800 Message-id: <006601d03c4b$68190bb0$384b2310$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQKDs63B3JtDSVeEmIqjDxgyUQN23AIvNw77ApRucngCJDL0eZs5zUPg Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t9jQd0bQqdDDH4tULZ4sn4Ws8WlRe4W e/aeZLG4vGsOmwOLx6ZVnWweuxd8ZvL4vEkugDmKyyYlNSezLLVI3y6BK2PhintsBes4K+av v8XSwHiGvYuRk0NCwESi6dIXFghbTOLCvfVsXYxcHEIC0xklLh17wAzh/GCU+HN/FytIFZuA isTyjv9MILaIgJpE774pYDazQKbEhP4X7BANlxglVhycxAaS4BQwlnh9tB1snbBAvMTueQ/A 4iwCqhIX974Ga+YVsJS4+/M8lC0o8WPyPRaIoVoS63ceh1ogL7F5zVtmiFMVJHacfc0IcYSb xOPmvewQNeISG4/cYpnAKDQLyahZSEbNQjJqFpKWBYwsqxhFUwuSC4qT0nON9IoTc4tL89L1 kvNzNzGCg/+Z9A7GVQ0WhxgFOBiVeHg9Hp8KEWJNLCuuzD3EKMHBrCTCq38MKMSbklhZlVqU H19UmpNafIhRmoNFSZxXyb4tREggPbEkNTs1tSC1CCbLxMEp1cAo1NrUc3h226+Y8wm/Llfv XqRyYmFh5kKTA1av17w8EHdZ44PLNQF5/XW/Z/RFhrjPypHYfkW3LWt+uMYK640auqc0VoUe D7ifcD3h6Ha1S8k7j8rvfLzJ7PJRlaKT3euzVh4VnyEe/23a6aTXUs27362RYPo/ZcnW3Zc2 buky6hRLm/nnt8pHfyWW4oxEQy3mouJEAF9aduZ6AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Friday, January 30, 2015 5:40 AM > To: Chao Yu > Cc: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [PATCH 4/5] f2fs: should fail mount when trying to recover data on read-only dev > > Hi Chao, > > This is another patch to fix that. > > From d241924043778d0fe01e9020d5771cc42cf246e6 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Thu, 29 Jan 2015 11:45:33 -0800 > Subject: [PATCH] f2fs: split UMOUNT and FASTBOOT flags > > This patch adds FASTBOOT flag into checkpoint as follows. > > - CP_UMOUNT_FLAG is set when system is umounted. > - CP_FASTBOOT_FLAG is set when intermediate checkpoint having node summaries > was done. > > So, if you get CP_UMOUNT_FLAG from checkpoint, the system was umounted cleanly. > Instead, if there was sudden-power-off, you can get CP_FASTBOOT_FLAG or nothing. Nice work, it looks good to me, and this can fix that issue. :) > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu