From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752687AbdBCHnZ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Feb 2017 02:43:25 -0500
Received: from out0-129.mail.aliyun.com ([140.205.0.129]:56977 "EHLO
        out0-129.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751520AbdBCHnY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Feb 2017 02:43:24 -0500
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R311e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03274;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---.7YLXdvn_1486107776;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Johannes Weiner'" <hannes@cmpxchg.org>,
        "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'Mel Gorman'" <mgorman@suse.de>, "'Michal Hocko'" <mhocko@suse.com>,
        "'Minchan Kim'" <minchan.kim@gmail.com>,
        "'Rik van Riel'" <riel@redhat.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20170202191957.22872-1-hannes@cmpxchg.org> <20170202191957.22872-7-hannes@cmpxchg.org>
In-Reply-To: <20170202191957.22872-7-hannes@cmpxchg.org>
Subject: Re: [PATCH 6/7] mm: vmscan: move dirty pages out of the way until they're flushed
Date: Fri, 03 Feb 2017 15:42:55 +0800
Message-ID: <006601d27df1$228a3940$679eabc0$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQIiXeFQfUokqyvJb5qCaarPWifPZQHsWELDoKe+Q+A=
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On February 03, 2017 3:20 AM Johannes Weiner wrote: 
> @@ -1063,7 +1063,7 @@ static unsigned long shrink_page_list(struct list_head *page_list,
>  			    PageReclaim(page) &&
>  			    test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
>  				nr_immediate++;
> -				goto keep_locked;
> +				goto activate_locked;

Out of topic but relevant IMHO, I can't find where it is cleared by grepping:

$ grep -nr PGDAT_WRITEBACK  linux-4.9/mm
linux-4.9/mm/vmscan.c:1019:	test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
linux-4.9/mm/vmscan.c:1777:	set_bit(PGDAT_WRITEBACK, &pgdat->flags);

It was removed in commit 1d82de618dd 
("mm, vmscan: make kswapd reclaim in terms of nodes")

Is it currently maintained somewhere else, Mel and John?

thanks
Hillf