From: Marc Zyngier <maz@kernel.org>
To: Joe Jin <joe.jin@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq/debugfs: add new config option for trigger interrupt from userspace
Date: Fri, 28 Feb 2020 16:37:17 +0000 [thread overview]
Message-ID: <006a08b8bfb991853ede8c9d1e29d6a7@kernel.org> (raw)
In-Reply-To: <44a7007d-9624-8ac7-e0ab-fab8bdd39848@oracle.com>
Hi Joe,
On 2020-02-28 05:42, Joe Jin wrote:
> commit 536e2e34bd00 ("genirq/debugfs: Triggering of interrupts from
> userspace") is allowed developer inject interrupts via irq debugfs,
> which
> is very useful during development phase, but on a production system,
> this
> is very dangerous, add new config option, developers can enable it as
> needed instead of enabling it by default when irq debugfs is enabled.
I don't really mind the patch (although it could be more elegant), but
in
general I object to most debugfs options being set on a production
kernel.
There is way too much information in most debugfs backends to be
comfortable
with it, and you can find things like page table dumps, for example...
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-02-28 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 5:42 [PATCH] genirq/debugfs: add new config option for trigger interrupt from userspace Joe Jin
2020-02-28 16:37 ` Marc Zyngier [this message]
2020-02-28 19:13 ` Joe Jin
2020-02-28 19:54 ` Marc Zyngier
2020-02-28 23:04 ` Joe Jin
2020-03-08 12:14 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=006a08b8bfb991853ede8c9d1e29d6a7@kernel.org \
--to=maz@kernel.org \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox