From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3874EC3F2D2 for ; Mon, 2 Mar 2020 08:24:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 122B9246A1 for ; Mon, 2 Mar 2020 08:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727314AbgCBIYj (ORCPT ); Mon, 2 Mar 2020 03:24:39 -0500 Received: from emcscan.emc.com.tw ([192.72.220.5]:40493 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726887AbgCBIYj (ORCPT ); Mon, 2 Mar 2020 03:24:39 -0500 X-Greylist: delayed 583 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Mar 2020 03:24:38 EST X-IronPort-AV: E=Sophos;i="5.56,253,1539619200"; d="scan'208";a="34654534" Received: from unknown (HELO webmail.emc.com.tw) ([192.168.10.1]) by emcscan.emc.com.tw with ESMTP; 02 Mar 2020 16:14:54 +0800 Received: from 192.168.10.23 by webmail.emc.com.tw with MailAudit ESMTP Server V5.0(2834:0:AUTH_RELAY) (envelope-from ); Mon, 02 Mar 2020 16:14:56 +0800 (CST) Received: from 192.168.55.71 by webmail.emc.com.tw with Mail2000 ESMTPA Server V7.00(2486:0:AUTH_LOGIN) (envelope-from ); Mon, 02 Mar 2020 16:14:55 +0800 (CST) From: "Johnny.Chuang" To: "'Peter Hutterer'" , "'Johnny Chuang'" Cc: "'Dmitry Torokhov'" , "'Benjamin Tissoires'" , , , "'Jennifer Tsai'" , "'James Chen'" , "'Paul Liang'" , "'Jeff Chuang'" References: <1582766000-23023-1-git-send-email-johnny.chuang.emc@gmail.com> <20200227223608.GB1087116@jelly> In-Reply-To: <20200227223608.GB1087116@jelly> Subject: RE: [PATCH] Input: elants_i2c - Report resolution information for touch major Date: Mon, 2 Mar 2020 16:14:51 +0800 Message-ID: <007201d5f06a$a5f341c0$f1d9c540$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKWH33oxoD7nuWwmg1Q/5rISp31bAHeLyTrpqWIE/A= Content-Language: zh-tw x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcMDUwMTBcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy1lMGYxMjliOS01YzVkLTExZWEtODUyMC03YzVjZjg3NDk0NzhcYW1lLXRlc3RcZTBmMTI5YmItNWM1ZC0xMWVhLTg1MjAtN2M1Y2Y4NzQ5NDc4Ym9keS50eHQiIHN6PSIyMjc3IiB0PSIxMzIyNzYxMDQ5MTI5NDI1OTkiIGg9Ik9jTEovN3VSbFA2eE5CRjlCK3J2Z2J6WXZvcz0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: true Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Peter Hutterer [mailto:peter.hutterer@who-t.net] > Sent: Friday, February 28, 2020 6:36 AM > To: Johnny Chuang > Cc: Dmitry Torokhov; Benjamin Tissoires; linux-kernel@vger.kernel.org; > linux-input@vger.kernel.org; Johnny Chuang; Jennifer Tsai; James Chen; Paul > Liang; Jeff Chuang > Subject: Re: [PATCH] Input: elants_i2c - Report resolution information for touch > major > > On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote: > > From: Johnny Chuang > > > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event. > > This information is needed in showing pressure/width radius. > > > > Signed-off-by: Johnny Chuang > > --- > > drivers/input/touchscreen/elants_i2c.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/input/touchscreen/elants_i2c.c > b/drivers/input/touchscreen/elants_i2c.c > > index 4911799..14c577c 100644 > > --- a/drivers/input/touchscreen/elants_i2c.c > > +++ b/drivers/input/touchscreen/elants_i2c.c > > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client > *client, > > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); > > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); > > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); > > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); > > official resolution for absinfo is "units per mm", so a value of 3 would > mean 3mm, is that correct? Correct. This resolution (1 unit/mm) is for all elan I2C touchscreen devices, including the touchscreen devices in the future. This information is from our firmware members. > > Not that it matters too much, since touch major is already all over the > place and needs userspace overrides for every device but it'd be nice to at > least make this useful out of the box on one device class. > > Reviewed-by: Peter Hutterer > > otherwise > > Cheers, > Peter > > > > > error = input_register_device(ts->input); > > if (error) { > > -- > > 2.7.4 > >