From: "Arnd Bergmann" <arnd@arndb.de>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Josh Poimboeuf" <jpoimboe@kernel.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Rae Moar" <rmoar@google.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Sergio González Collado" <sergio.collado@gmail.com>,
"David Gow" <davidgow@google.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas.schier@linux.dev>,
"Mostafa Saleh" <smostafa@google.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/mksysmap: skip objtool __pfx_ symbols
Date: Fri, 11 Apr 2025 09:47:51 +0200 [thread overview]
Message-ID: <0073e739-e3aa-4743-ad2d-29d7c969f454@app.fastmail.com> (raw)
In-Reply-To: <20250411065054.GM9833@noisy.programming.kicks-ass.net>
On Fri, Apr 11, 2025, at 08:50, Peter Zijlstra wrote:
> On Tue, Apr 08, 2025 at 06:58:49PM -0700, Josh Poimboeuf wrote:
>> On Fri, Mar 28, 2025 at 11:48:19AM +0100, Arnd Bergmann wrote:
>>
>> For example, FineIBT writes code in the __pfx area which can trigger an
>> #UD. And we'd want a sane backtrace for that.
>
> On top of that, clang kcfi builds do a similar thing, they will generate
> __cfi_ prefixed symbols.
>
> And yes, those symbols exist for a reason, there is code there under
> various circumstances and backtraces look really weird without these
> symbols on -- notably the code in the prefix will be attributed to
> whatever symbol comes before, most confusing.
>
> So yeah, don't remove these symbols, and fix the kunit test.
kallsyms already removes some CFI symbol names based on regular
expressions:
# CFI type identifiers
/ __kcfi_typeid_/d
/ __kvm_nvhe___kcfi_typeid_/d
/ __pi___kcfi_typeid_/d
Do you think it should not remove some of them?
I ran into another problem with generated symbols that I don't
understand yet, and added this line to avoid the build failures:
/ _GLOBAL__sub_/d
This one is 534 characters long:
_GLOBAL__sub_I_65535_1_snnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nnng1h2i3j4k5l6m7ng1h2i3j4k5l6m7nng1h2i3j4k5l6m7ng1h2i3j4k5l6m7n
Arnd
next prev parent reply other threads:[~2025-04-11 7:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 10:48 [PATCH] scripts/mksysmap: skip objtool __pfx_ symbols Arnd Bergmann
2025-04-09 1:58 ` Josh Poimboeuf
2025-04-11 6:50 ` Peter Zijlstra
2025-04-11 7:47 ` Arnd Bergmann [this message]
2025-04-11 10:58 ` Peter Zijlstra
2025-04-12 14:22 ` Steven Rostedt
2025-04-13 2:22 ` Nathan Chancellor
2025-04-15 17:39 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0073e739-e3aa-4743-ad2d-29d7c969f454@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davidgow@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=peterz@infradead.org \
--cc=rmoar@google.com \
--cc=sergio.collado@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox