public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>,
	"'LKML'" <linux-kernel@vger.kernel.org>
Cc: "'Richard Purdie'" <rpurdie@rpsys.net>,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 07/17] backlight: ili9320: fix checkpatch error and warning
Date: Tue, 16 Oct 2012 16:29:27 +0900	[thread overview]
Message-ID: <007801cdab6f$f92b5aa0$eb820fe0$%han@samsung.com> (raw)
In-Reply-To: <007101cdab6f$6c8bc030$45a34090$%han@samsung.com>

This patch fixes the checkpatch error and warning as below:

WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
WARNING: braces {} are not necessary for single statement blocks
ERROR: code indent should use tabs where possible

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
 drivers/video/backlight/ili9320.c |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/video/backlight/ili9320.c b/drivers/video/backlight/ili9320.c
index 9327cd1..a66cfd1 100644
--- a/drivers/video/backlight/ili9320.c
+++ b/drivers/video/backlight/ili9320.c
@@ -45,7 +45,7 @@ static inline int ili9320_write_spi(struct ili9320 *ili,
 	/* second message is the data to transfer */
 
 	data[0] = spi->id | ILI9320_SPI_DATA  | ILI9320_SPI_WRITE;
- 	data[1] = value >> 8;
+	data[1] = value >> 8;
 	data[2] = value;
 
 	return spi_sync(spi->dev, &spi->message);
@@ -56,7 +56,6 @@ int ili9320_write(struct ili9320 *ili, unsigned int reg, unsigned int value)
 	dev_dbg(ili->dev, "write: reg=%02x, val=%04x\n", reg, value);
 	return ili->write(ili, reg, value);
 }
-
 EXPORT_SYMBOL_GPL(ili9320_write);
 
 int ili9320_write_regs(struct ili9320 *ili,
@@ -74,7 +73,6 @@ int ili9320_write_regs(struct ili9320 *ili,
 
 	return 0;
 }
-
 EXPORT_SYMBOL_GPL(ili9320_write_regs);
 
 static void ili9320_reset(struct ili9320 *lcd)
@@ -260,7 +258,6 @@ int __devinit ili9320_probe_spi(struct spi_device *spi,
 
 	return ret;
 }
-
 EXPORT_SYMBOL_GPL(ili9320_probe_spi);
 
 int ili9320_remove(struct ili9320 *ili)
@@ -271,7 +268,6 @@ int ili9320_remove(struct ili9320 *ili)
 
 	return 0;
 }
-
 EXPORT_SYMBOL_GPL(ili9320_remove);
 
 #ifdef CONFIG_PM
@@ -296,20 +292,17 @@ int ili9320_suspend(struct ili9320 *lcd, pm_message_t state)
 
 	return 0;
 }
-
 EXPORT_SYMBOL_GPL(ili9320_suspend);
 
 int ili9320_resume(struct ili9320 *lcd)
 {
 	dev_info(lcd->dev, "resuming from power state %d\n", lcd->power);
 
-	if (lcd->platdata->suspend == ILI9320_SUSPEND_DEEP) {
+	if (lcd->platdata->suspend == ILI9320_SUSPEND_DEEP)
 		ili9320_write(lcd, ILI9320_POWER1, 0x00);
-	}
 
 	return ili9320_power(lcd, FB_BLANK_UNBLANK);
 }
-
 EXPORT_SYMBOL_GPL(ili9320_resume);
 #endif
 
@@ -318,7 +311,6 @@ void ili9320_shutdown(struct ili9320 *lcd)
 {
 	ili9320_power(lcd, FB_BLANK_POWERDOWN);
 }
-
 EXPORT_SYMBOL_GPL(ili9320_shutdown);
 
 MODULE_AUTHOR("Ben Dooks <ben-linux@fluff.org>");
-- 
1.7.1



  parent reply	other threads:[~2012-10-16  7:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16  7:25 [PATCH 01/17] backlight: 88pm860x_bl: fix checkpatch warning Jingoo Han
2012-10-16  7:26 ` [PATCH 02/17] backlight: atmel-pwm-bl: " Jingoo Han
2012-10-16  7:27 ` [PATCH 03/17] backlight: corgi_lcd: fix checkpatch error and warning Jingoo Han
2012-10-16  7:27 ` [PATCH 04/17] backlight: da903x_bl: fix checkpatch warning Jingoo Han
2012-10-16  7:28 ` [PATCH 05/17] backlight: generic_bl: " Jingoo Han
2012-10-16  7:28 ` [PATCH 06/17] backlight: hp680_bl: fix checkpatch error and warning Jingoo Han
2012-10-16  7:29 ` Jingoo Han [this message]
2012-10-16  7:30 ` [PATCH 08/17] backlight: jornada720: " Jingoo Han
2012-10-16 15:46   ` Kristoffer Eriksson
2012-10-16  7:30 ` [PATCH 09/17] backlight: l4f00242t03: fix checkpatch warning Jingoo Han
2012-10-16  7:30 ` [PATCH 10/17] backlight: lm3630: " Jingoo Han
2012-10-16  7:31 ` [PATCH 11/17] backlight: locomolcd: fix checkpatch error and warning Jingoo Han
2012-10-16  7:31 ` [PATCH 12/17] backlight: omap1: fix checkpatch warning Jingoo Han
2012-10-16  7:32 ` [PATCH 13/17] backlight: pcf50633: " Jingoo Han
2012-10-16  7:32 ` [PATCH 14/17] backlight: platform_lcd: fix checkpatch error Jingoo Han
2012-10-16  7:33 ` [PATCH 15/17] backlight: tdo24m: fix checkpatch warning Jingoo Han
2012-10-16  7:33 ` [PATCH 16/17] backlight: tosa: fix checkpatch error and warning Jingoo Han
2012-10-16  7:34 ` [PATCH 17/17] backlight: vgg2432a4: fix checkpatch warning Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007801cdab6f$f92b5aa0$eb820fe0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox