From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>,
<s-vadapalli@ti.com>
Subject: Re: [PATCH net] net: phy: dp83867: add w/a for packet errors seen with short cables
Date: Tue, 9 May 2023 10:12:16 +0530 [thread overview]
Message-ID: <007ca679-2ba7-635f-942f-deee52e70117@ti.com> (raw)
In-Reply-To: <20230508190035.24b5710e@kernel.org>
On 09/05/23 07:30, Jakub Kicinski wrote:
> Thanks for the patch! Some nit picks below..
>
> On Mon, 8 May 2023 12:30:19 +0530 Siddharth Vadapalli wrote:
>> + err = phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_DSP_FFE_CFG, 0X0E81);
>
> Pleas wrap this line at 80 characters, there's no reason for it
> to be this long.
>
> And 0x prefix should not be in upper case, here and in the new define
> you're adding.
Thank you for pointing out the issues. I will fix them and post the v2 patch.
--
Regards,
Siddharth.
prev parent reply other threads:[~2023-05-09 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 7:00 [PATCH net] net: phy: dp83867: add w/a for packet errors seen with short cables Siddharth Vadapalli
2023-05-09 2:00 ` Jakub Kicinski
2023-05-09 4:42 ` Siddharth Vadapalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=007ca679-2ba7-635f-942f-deee52e70117@ti.com \
--to=s-vadapalli@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox