RE: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.

["Madhusudhan" <madhu.cr@ti.com>]

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Madhusudhan
> Sent: Monday, April 05, 2010 12:19 PM
> To: me@felipebalbi.com; 'kishore kadiyala'
> Cc: 'Vimal Singh'; tony@atomide.com; svenkatr@ti.com; linux-
> omap@vger.kernel.org; linux-kernel@vger.kernel.org;
> jarkko.lavinen@nokia.com
> Subject: RE: [PATCH v3] OMAP: Fix for bus width which improves SD card's
> peformance.
> 
> 
> 
> > -----Original Message-----
> > From: Felipe Balbi [mailto:me@felipebalbi.com]
> > Sent: Monday, April 05, 2010 11:49 AM
> > To: kishore kadiyala
> > Cc: Madhusudhan; Vimal Singh; tony@atomide.com; svenkatr@ti.com; linux-
> > omap@vger.kernel.org; linux-kernel@vger.kernel.org;
> > jarkko.lavinen@nokia.com
> > Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's
> > peformance.
> >
> > Hi,
> >
> > On Mon, Apr 05, 2010 at 06:26:16PM +0530, kishore kadiyala wrote:
> > > @@ -2091,9 +2091,9 @@ static int __init omap_hsmmc_probe(struct
> > >  	mmc->caps |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
> > >  		     MMC_CAP_WAIT_WHILE_BUSY;
> > >
> > > -	if (mmc_slot(host).wires >= 8)
> > > -		mmc->caps |= MMC_CAP_8_BIT_DATA;
> > > -	else if (mmc_slot(host).wires >= 4)
> > > +	if (mmc_slot(host).wires == 8)
> > > +		mmc->caps |= (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA);
> > > +	else if (mmc_slot(host).wires == 4)
> > >  		mmc->caps |= MMC_CAP_4_BIT_DATA;
> >
> > I believe it would be enough to just remove the 'else', so the code
> > would look like:
> >
> > if (mmc_slot(host).wires >= 8)
> > 	mmc->caps |= MMC_CAP_8_BIT_DATA;
> > if (mmc_slot(host).wires >= 4)
> 
> Since the first if command already checks for the 8-bit the second check
> like >= 4 is definitely not readable in my opinion.
> 
> Functionally do you see anything wrong with this patch??
> 

Just to clarify my earlier comment on the patch was to resubmit like below:

if (mmc_slot(host).wires == 8)
	mmc->caps |= (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA);
if (mmc_slot(host).wires == 4)
  		mmc->caps |= MMC_CAP_4_BIT_DATA;

IMHO, this should be good enough.

Regards,
Madhu


> > 	mmc->caps |= MMC_CAP_4_BIT_DATA;
> >
> > --
> > balbi
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html