From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>,
"'LKML'" <linux-kernel@vger.kernel.org>
Cc: "'Richard Purdie'" <rpurdie@rpsys.net>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 16/17] backlight: tosa: fix checkpatch error and warning
Date: Tue, 16 Oct 2012 16:33:53 +0900 [thread overview]
Message-ID: <008101cdab70$9789f4e0$c69ddea0$%han@samsung.com> (raw)
In-Reply-To: <007101cdab6f$6c8bc030$45a34090$%han@samsung.com>
This patch fixes the checkpatch error and warning as below:
WARNING: line over 80 characters
ERROR: spaces required around that '?' (ctx:VxW)
ERROR: space required after that ',' (ctx:VxV)
Also, unnecessary lines are removed.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/video/backlight/tosa_bl.c | 4 ++--
drivers/video/backlight/tosa_lcd.c | 16 +++++++++-------
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
index 49342e1..03c6ec2 100644
--- a/drivers/video/backlight/tosa_bl.c
+++ b/drivers/video/backlight/tosa_bl.c
@@ -90,7 +90,8 @@ static int __devinit tosa_bl_probe(struct i2c_client *client,
if (!data)
return -ENOMEM;
- data->comadj = sharpsl_param.comadj == -1 ? COMADJ_DEFAULT : sharpsl_param.comadj;
+ data->comadj = sharpsl_param.comadj == -1 ?
+ COMADJ_DEFAULT : sharpsl_param.comadj;
ret = devm_gpio_request(&client->dev, TOSA_GPIO_BL_C20MA, "backlight");
if (ret) {
@@ -163,7 +164,6 @@ static const struct i2c_device_id tosa_bl_id[] = {
{ },
};
-
static struct i2c_driver tosa_bl_driver = {
.driver = {
.name = "tosa-bl",
diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c
index 33047a6..bcd97c5 100644
--- a/drivers/video/backlight/tosa_lcd.c
+++ b/drivers/video/backlight/tosa_lcd.c
@@ -63,7 +63,7 @@ static int tosa_tg_send(struct spi_device *spi, int adrs, uint8_t data)
int tosa_bl_enable(struct spi_device *spi, int enable)
{
/* bl_enable GP04=1 otherwise GP04=0*/
- return tosa_tg_send(spi, TG_GPODR2, enable? 0x01 : 0x00);
+ return tosa_tg_send(spi, TG_GPODR2, enable ? 0x01 : 0x00);
}
EXPORT_SYMBOL(tosa_bl_enable);
@@ -91,15 +91,17 @@ static void tosa_lcd_tg_on(struct tosa_lcd_data *data)
tosa_tg_send(spi, TG_PNLCTL, value);
/* TG LCD pannel power up */
- tosa_tg_send(spi, TG_PINICTL,0x4);
+ tosa_tg_send(spi, TG_PINICTL, 0x4);
mdelay(50);
/* TG LCD GVSS */
- tosa_tg_send(spi, TG_PINICTL,0x0);
+ tosa_tg_send(spi, TG_PINICTL, 0x0);
if (!data->i2c) {
- /* after the pannel is powered up the first time, we can access the i2c bus */
- /* so probe for the DAC */
+ /*
+ * after the pannel is powered up the first time,
+ * we can access the i2c bus so probe for the DAC
+ */
struct i2c_adapter *adap = i2c_get_adapter(0);
struct i2c_board_info info = {
.type = "tosa-bl",
@@ -115,11 +117,11 @@ static void tosa_lcd_tg_off(struct tosa_lcd_data *data)
struct spi_device *spi = data->spi;
/* TG LCD VHSA off */
- tosa_tg_send(spi, TG_PINICTL,0x4);
+ tosa_tg_send(spi, TG_PINICTL, 0x4);
mdelay(50);
/* TG LCD signal off */
- tosa_tg_send(spi, TG_PINICTL,0x6);
+ tosa_tg_send(spi, TG_PINICTL, 0x6);
mdelay(50);
/* TG Off */
--
1.7.1
next prev parent reply other threads:[~2012-10-16 7:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 7:25 [PATCH 01/17] backlight: 88pm860x_bl: fix checkpatch warning Jingoo Han
2012-10-16 7:26 ` [PATCH 02/17] backlight: atmel-pwm-bl: " Jingoo Han
2012-10-16 7:27 ` [PATCH 03/17] backlight: corgi_lcd: fix checkpatch error and warning Jingoo Han
2012-10-16 7:27 ` [PATCH 04/17] backlight: da903x_bl: fix checkpatch warning Jingoo Han
2012-10-16 7:28 ` [PATCH 05/17] backlight: generic_bl: " Jingoo Han
2012-10-16 7:28 ` [PATCH 06/17] backlight: hp680_bl: fix checkpatch error and warning Jingoo Han
2012-10-16 7:29 ` [PATCH 07/17] backlight: ili9320: " Jingoo Han
2012-10-16 7:30 ` [PATCH 08/17] backlight: jornada720: " Jingoo Han
2012-10-16 15:46 ` Kristoffer Eriksson
2012-10-16 7:30 ` [PATCH 09/17] backlight: l4f00242t03: fix checkpatch warning Jingoo Han
2012-10-16 7:30 ` [PATCH 10/17] backlight: lm3630: " Jingoo Han
2012-10-16 7:31 ` [PATCH 11/17] backlight: locomolcd: fix checkpatch error and warning Jingoo Han
2012-10-16 7:31 ` [PATCH 12/17] backlight: omap1: fix checkpatch warning Jingoo Han
2012-10-16 7:32 ` [PATCH 13/17] backlight: pcf50633: " Jingoo Han
2012-10-16 7:32 ` [PATCH 14/17] backlight: platform_lcd: fix checkpatch error Jingoo Han
2012-10-16 7:33 ` [PATCH 15/17] backlight: tdo24m: fix checkpatch warning Jingoo Han
2012-10-16 7:33 ` Jingoo Han [this message]
2012-10-16 7:34 ` [PATCH 17/17] backlight: vgg2432a4: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008101cdab70$9789f4e0$c69ddea0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox