RE: [PATCH v2 2/4] arm64: dts: exynos: add initial CMU clock nodes in Exynos Auto v920

Alim Akhtar
2024-07-10T02:31:00Z

Hello Sunyeal,

> -----Original Message-----
> From: sunyeal.hong <sunyeal.hong@samsung.com>
>
[snip]
> > Subject: RE: [PATCH v2 2/4] arm64: dts: exynos: add initial CMU clock
> > nodes in Exynos Auto v920
> >
> >
> >
> > > -----Original Message-----
> > > From: Sunyeal Hong <sunyeal.hong@samsung.com>
> > > Sent: Monday, July 8, 2024 4:43 AM
> > > To: Krzysztof Kozlowski <krzk@kernel.org>; Sylwester Nawrocki
> > > <s.nawrocki@samsung.com>; Chanwoo Choi
> <cw00.choi@samsung.com>; Alim
> > > Akhtar <alim.akhtar@samsung.com>; Michael Turquette
[Snip]
> > > + cmu_peric0: clock-controller@10800000 {
> > > + compatible = "samsung,exynosautov920-cmu-
> > > peric0";
> > > + reg = <0x10800000 0x8000>;
> > Please cross check the size of the register range, this looks to be
> > more then what is needed.
> >
> In the case of preic0, the size is up to 0x7088. The CMU block SFR area of ​
> ExynosAuto v920 is generally specified up to 0x8000. There are differences
> for each block, but the settings are the same.
> Do you think it is necessary to change the actual size of each block?
To avoid any overlap between difference SFR region, better to mention the exact size of the SFR region.

[snip]
> > > --
> > > 2.45.2
> >
> >
>
> Please review my answer again.
>
> Thanks,
> Sunyeal Hong
>