RE: [PATCH v2 2/4] arm64: dts: exynos: add initial CMU clock nodes in Exynos Auto v920

sunyeal.hong
2024-07-10T06:59:12Z

Hello Alim,

> -----Original Message-----
> From: Alim Akhtar <alim.akhtar@samsung.com>
> Sent: Wednesday, July 10, 2024 11:31 AM
> To: 'sunyeal.hong' <sunyeal.hong@samsung.com>; 'Krzysztof Kozlowski'
> <krzk@kernel.org>; 'Sylwester Nawrocki' <s.nawrocki@samsung.com>; 'Chanwoo
> Choi' <cw00.choi@samsung.com>; 'Michael Turquette'
> <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>; 'Rob
> Herring' <robh@kernel.org>; 'Conor Dooley' <conor+dt@kernel.org>
> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH v2 2/4] arm64: dts: exynos: add initial CMU clock
> nodes in Exynos Auto v920
>
> Hello Sunyeal,
>
> > -----Original Message-----
> > From: sunyeal.hong <sunyeal.hong@samsung.com>
> >
> [snip]
> > > Subject: RE: [PATCH v2 2/4] arm64: dts: exynos: add initial CMU
> > > clock nodes in Exynos Auto v920
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Sunyeal Hong <sunyeal.hong@samsung.com>
> > > > Sent: Monday, July 8, 2024 4:43 AM
> > > > To: Krzysztof Kozlowski <krzk@kernel.org>; Sylwester Nawrocki
> > > > <s.nawrocki@samsung.com>; Chanwoo Choi
> > <cw00.choi@samsung.com>; Alim
> > > > Akhtar <alim.akhtar@samsung.com>; Michael Turquette
> [Snip]
> > > > + cmu_peric0: clock-controller@10800000 {
> > > > + compatible = "samsung,exynosautov920-cmu-
> > > > peric0";
> > > > + reg = <0x10800000 0x8000>;
> > > Please cross check the size of the register range, this looks to be
> > > more then what is needed.
> > >
> > In the case of preic0, the size is up to 0x7088. The CMU block SFR
> > area of ​ ExynosAuto v920 is generally specified up to 0x8000. There
> > are differences for each block, but the settings are the same.
> > Do you think it is necessary to change the actual size of each block?
> To avoid any overlap between difference SFR region, better to mention the
> exact size of the SFR region.
>
In ExynosAuto, the SFR of each block has an offset of 0x10000. So I don't think SFR will be overlapped.
In the case of CMU SFR, there is no size over 0x8000, so I think it would be better to maintain that value.
Please give me your opinion again.
> [snip]
> > > > --
> > > > 2.45.2
> > >
> > >
> >
> > Please review my answer again.
> >
> > Thanks,
> > Sunyeal Hong
> >
>
>

Thanks,
Sunyeal Hong