RE: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration

["Alim Akhtar" <alim.akhtar@samsung.com>]

Hi Yashwant,

> -----Original Message-----
> From: Yashwant Varur <yashwant.v@samsung.com>
> Sent: Wednesday, April 23, 2025 11:31 AM
> To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> alim.akhtar@samsung.com; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: cs0617.lee@samsung.com; g.naidu@samsung.com;
> niyas.ahmed@samsung.com; yashwant.v@samsung.com
> Subject: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration
> 
> This patch adds the ethernet pin configuration.
> 
Please follow https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
to describe our changes.

> Signed-off-by: Yashwant Varur <yashwant.v@samsung.com>
> Signed-off-by: Changsub Lee <cs0617.lee@samsung.com>
> ---
>  .../dts/exynos/exynosautov920-pinctrl.dtsi    | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> index 663e8265cbf5..778584d339d5 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank {
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  	};
> +
> +	eth0_pps_out: eth0_pps_out {
> +		samsung,pins = "gph3-0";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +	};
> +
> +	eth0_rgmii: eth0_rgmii {
> +		samsung,pins = "gph3-1", "gph3-2", "gph3-3", "gph3-4",
> +				"gph3-5", "gph3-6", "gph3-7", "gph4-0",
> +				"gph4-1", "gph4-2", "gph4-3", "gph4-4";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +	};
> +
> +	eth0_mdc_mdio: eth0_mdc_mdio {
> +		samsung,pins = "gph4-5", "gph4-6";
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
No need to set drive strength and pull-{up/down}??