From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751664AbbIQMV1 (ORCPT ); Thu, 17 Sep 2015 08:21:27 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:43535 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbbIQMV0 (ORCPT ); Thu, 17 Sep 2015 08:21:26 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-e5-55fab044272e From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <00f201d0ec5c$8274e670$875eb350$@samsung.com> <20150916180112.GB99097@jaegeuk-mac02.mot.com> In-reply-to: <20150916180112.GB99097@jaegeuk-mac02.mot.com> Subject: RE: [PATCH 2/7] f2fs: do in batches truncation in truncate_hole Date: Thu, 17 Sep 2015 20:20:47 +0800 Message-id: <009a01d0f143$5f5bf7f0$1e13e7d0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQJaS+J2i1IK7C0bZGD0j/59exqb7AKoso1qnRf29AA= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsVy+t9jQV3XDb9CDaafZbN4sn4Ws8WlRe4W l3fNYXNg9ti0qpPNY/eCz0wenzfJBTBHcdmkpOZklqUW6dslcGVsuP6etWA+S8XS6xfYGhg3 M3cxcnJICJhI3Hv3nxXCFpO4cG89WxcjF4eQwCxGidtNF1khnFeMEjM+bQKrYhNQkVje8Z8J xBYRUJPo3TcFzGYW8JBo7PgOViMkkCUx7V0nmM0pYC2xY+tFMFsYqOb5k5Vg9SwCqhJXf8wE u4JXwFJi69PnLBC2oMSPyfdYIGZqSazfeRxqvrzE5jVvoa5WkNhx9jUjxA1WEr8mLGOHqBGX 2HjkFssERqFZSEbNQjJqFpJRs5C0LGBkWcUokVqQXFCclJ5rmJdarlecmFtcmpeul5yfu4kR HPbPpHYwHtzlfohRgINRiYdXweVXqBBrYllxZe4hRgkOZiURXvUFQCHelMTKqtSi/Pii0pzU 4kOM0hwsSuK8siufhQoJpCeWpGanphakFsFkmTg4pRoY7Vo3BvV2h2zxNhPzag5puhG2LXTf gW8v+H6ZOvJNslP9rp1gGF3Femee4NG26BvWzwwFTUQ41k0uKstumN1W83PN1U/XDzdu039T nvK1M/rMqfkRjlVyRs4OfQUaofsSVrMJWi9hmPjwu2r9uYhW3WSjqJiChTz8Ynvy+PlvzA/e ZCicwKjEUpyRaKjFXFScCAB+QtUKdwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Thursday, September 17, 2015 2:01 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/7] f2fs: do in batches truncation in truncate_hole > > Hi Chao, > > How about changing the original patch slightly like below? > > o don't have to use index variable > o should not skip the entire dnode indices, when one of them is -ENOENT Agree, thanks for your review! :) Thanks,