From: "John Hawkes" <hawkes@sgi.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Nick Piggin" <nickpiggin@yahoo.com.au>,
"Dinakar Guniguntala" <dino@in.ibm.com>,
"Andrew Morton" <akpm@osdl.org>, <linux-kernel@vger.kernel.org>,
"Jack Steiner" <steiner@sgi.com>, "Paul Jackson" <pj@sgi.com>
Subject: Re: [patch -mm] scheduler cache hot autodetect, isolcpus fix
Date: Mon, 12 Dec 2005 12:20:05 -0800 [thread overview]
Message-ID: <00a401c5ff59$7958c480$6f00a8c0@comcast.net> (raw)
In-Reply-To: 20051210122548.GB25065@elte.hu
I'm looking at 2.6.15-rc5-mm2 and there is still a problem: the
migration_cost[] array is disappearing after boot, which leads to completely
bogus migration_cost[] values when dynamic sched domains are declared.
The fix:
Index: linux/kernel/sched.c
==========================================================
--- linux.orig/kernel/sched.c 2005-12-12 10:30:24.000000000 -0800
+++ linux/kernel/sched.c 2005-12-12 11:25:27.000000000 -0800
@@ -5279,7 +5279,7 @@
*/
#define MAX_DOMAIN_DISTANCE 32
-static __initdata unsigned long long migration_cost[MAX_DOMAIN_DISTANCE] =
+static unsigned long long migration_cost[MAX_DOMAIN_DISTANCE] =
{ [ 0 ... MAX_DOMAIN_DISTANCE-1 ] = -1LL };
/*
next prev parent reply other threads:[~2005-12-12 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-09 20:54 [PATCH] -mm tree: broken "dynamic sched domains" and "migration cost" hawkes
2005-12-10 0:06 ` Paul Jackson
2005-12-10 12:02 ` [patch -mm] scheduler cache hot autodetect, print less Ingo Molnar
2005-12-10 12:25 ` [patch -mm] scheduler cache hot autodetect, isolcpus fix Ingo Molnar
2005-12-12 20:20 ` John Hawkes [this message]
2005-12-13 7:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00a401c5ff59$7958c480$6f00a8c0@comcast.net' \
--to=hawkes@sgi.com \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox