Re: [PATCH 17/18] backlight: jornada720: remove 'else' after a return

Lee Jones
2014-08-26T16:28:24Z

On Tue, 26 Aug 2014, Jingoo Han wrote:

> Fixed the following checkpatch warning.
>
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/jornada720_lcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> index 228bc319de19..1cf3d59f1e7f 100644
> --- a/drivers/video/backlight/jornada720_lcd.c
> +++ b/drivers/video/backlight/jornada720_lcd.c
> @@ -30,8 +30,8 @@ static int jornada_lcd_get_power(struct lcd_device *ld)
> /* LDD2 in PPC = LCD POWER */
> if (PPSR & PPC_LDD2)
> return FB_BLANK_UNBLANK; /* PW ON */
> - else
> - return FB_BLANK_POWERDOWN; /* PW OFF */
> +
> + return FB_BLANK_POWERDOWN; /* PW OFF */

How about:

return PPSR & PPC_LDD2 ? FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN;

> }
>
> static int jornada_lcd_get_contrast(struct lcd_device *ld)