From: Inki Dae <inki.dae@samsung.com>
To: sw0312.kim@samsung.com, "'Wei Yongjun'" <weiyj.lk@gmail.com>
Cc: jy0922.shim@samsung.com, kyungmin.park@samsung.com,
airlied@linux.ie, yongjun_wei@trendmicro.com.cn,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: RE: [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping()
Date: Mon, 10 Dec 2012 15:29:14 +0900 [thread overview]
Message-ID: <00b301cdd69f$ac5220a0$04f661e0$%dae@samsung.com> (raw)
In-Reply-To: <50C57DB9.8070100@samsung.com>
> -----Original Message-----
> From: 김승우 [mailto:sw0312.kim@samsung.com]
> Sent: Monday, December 10, 2012 3:14 PM
> To: Wei Yongjun
> Cc: inki.dae@samsung.com; jy0922.shim@samsung.com;
> kyungmin.park@samsung.com; airlied@linux.ie; yongjun_wei@trendmicro.com.cn;
> linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org;
> sw0312.kim@samsung.com
> Subject: Re: [PATCH -next] drm/exynos/iommu: fix return value check in
> drm_create_iommu_mapping()
>
>
>
> On 2012년 12월 07일 21:50, Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > In case of error, function arm_iommu_create_mapping() returns
> > ERR_PTR() and never returns NULL. The NULL test in the return
> > value check should be replaced with IS_ERR().
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > ---
> > drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> > index 09db198..3b3d3a6 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> > @@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device
> *drm_dev)
> > mapping = arm_iommu_create_mapping(&platform_bus_type, priv-
> >da_start,
> > priv->da_space_size,
> > priv->da_space_order);
> > - if (!mapping)
> > + if (IS_ERR(mapping))
> > return -ENOMEM;
>
> One more fix is needed here.
> - return -ENOMEM;
> + return PTR_ERR(mapping);
Oh, good point, I missed. Please re-send it.
Thanks,
Inki Dae
>
> >
> > dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
> >
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
>
> --
> Seung-Woo Kim
> Samsung Software R&D Center
> --
prev parent reply other threads:[~2012-12-10 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 12:50 [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping() Wei Yongjun
2012-12-10 6:14 ` 김승우
2012-12-10 6:29 ` Inki Dae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b301cdd69f$ac5220a0$04f661e0$%dae@samsung.com' \
--to=inki.dae@samsung.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).