Re: [PATCH v20 13/18] x86/resctrl: Handle removing directories in Sub-NUMA Cluster (SNC) mode

Reinette Chatre
2024-06-20T21:30:39Z

Hi Tony,

On 6/10/24 11:35 AM, Tony Luck wrote:
> In SNC mode there are multiple subdirectories in each L3 level monitor
> directory (one for each SNC node). If all the CPUs in an SNC node are
> taken offline, just remove the SNC directory for that node. In

(nit: watch for random extra spaces)

> non-SNC mode, or when the last SNC node directory is removed, also
> remove the L3 monitor directory.

Perhaps drop the "also" since it is not relevant to non-SNC mode?

>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 41 +++++++++++++++++++++-----
> 1 file changed, 34 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index fc7f3f139800..5142ce43ac13 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -3004,20 +3004,47 @@ static int mon_addfile(struct kernfs_node *parent_kn, const char *name,
>
> /*
> * Remove all subdirectories of mon_data of ctrl_mon groups
> - * and monitor groups with given domain id.
> + * and monitor groups for the given domain.
> */
> static void rmdir_mondata_subdir_allrdtgrp(struct rdt_resource *r,
> - unsigned int dom_id)
> + struct rdt_mon_domain *d)
> {
> struct rdtgroup *prgrp, *crgrp;
> + struct kernfs_node *kn;
> + char subname[32];
> char name[32];
>
> + sprintf(name, "mon_%s_%02d", r->name, d->ci->id);
> + if (r->mon_scope != RESCTRL_L3_CACHE) {

Same comments about positive check and subtle assignment as in previous
patch.

> + /*
> + * SNC mode: Unless the last domain is being removed must
> + * just remove the SNC subdomain.
> + */

Can this comment be moved to be part of the top function comments? It is
not relevant to code being commented here and only seems to be here to
avoid duplicating it in the spots where it is relevant.

> + sprintf(subname, "mon_sub_%s_%02d", r->name, d->hdr.id);
> + }
> +

Reinette