Re: [PATCH v20 17/18] x86/resctrl: Sub-NUMA Cluster (SNC) detection

Markus Elfring
2024-06-21T17:06:00Z

…
> Add the missing definition of pr_fmt() to monitor.c. …

How do you think about to add the tag “Fixes” accordingly?

…
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
…
> +static __init int snc_get_config(void)
> +{
…
> + cpus_read_lock();
> + if (num_online_cpus() != num_present_cpus())
> + pr_warn("Some CPUs offline, SNC detection may be incorrect\n");
> + cpus_read_unlock();
…

Would you become interested to apply a statement like “guard(cpus_read_lock)();”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L133

Regards,
Markus