From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S967177AbcHBPWS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 11:22:18 -0400
Received: from smtp.opengridcomputing.com ([72.48.136.20]:48242 "EHLO
	smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S967041AbcHBPVt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 11:21:49 -0400
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Steven Rostedt'" <rostedt@goodmis.org>
Cc: "'Baole Ni'" <baolex.ni@intel.com>, <swise@chelsio.com>,
        <dledford@redhat.com>, <sean.hefty@intel.com>,
        <hal.rosenstock@gmail.com>, <airlied@linux.ie>, <kgene@kernel.org>,
        <k.kozlowski@samsung.com>, <dougthompson@xmission.com>, <bp@alien8.de>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <chuansheng.liu@intel.com>, <hch@infradead.org>, <matanb@mellanox.com>,
        <markb@mellanox.com>, <jgunthorpe@obsidianresearch.com>,
        <dean.luick@intel.com>
References: <20160802105341.30676-1-baolex.ni@intel.com> <006201d1ecc7$f6889bd0$e399d370$@opengridcomputing.com> <20160802150832.GA26697@home.goodmis.org>
In-Reply-To: <20160802150832.GA26697@home.goodmis.org>
Subject: RE: [PATCH 0254/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 10:20:07 -0500
Message-ID: <00c701d1ecd1$5a4caef0$0ee60cd0$@opengridcomputing.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQGrk9jhML90z6zUsKMvF76DD6ByRgHTzY42Aj97YSygYeA+kA==
Content-Language: en-us
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 
> On Tue, Aug 02, 2016 at 09:12:54AM -0500, Steve Wise wrote:
> > Acked-by: Steve Wise <swise@opengridcomputing.com>
> >
> 
> I have to ask, why did you ack all these? There's several things wrong with
> this patch series, but even the point of the patch is mistaken. It makes
> readable code much less readable. When you chmod a file, do you type
> 
>   chmod 0444 file
> 
> or do you write
> 
>   chmod S_IRUSR|S_IRGRP|S_IROTH file
> 
> ?
> 
> Which of the above is easier to figure what is being changed?
>

I assumed this was some global "fix up".   
 
> Not to mention, because the subject is the same for all 1285 patches, and you
> deleted the content of the patch in your ack, there's no way to know what
> exactly this ack is for (I haven't received the original patch yet because
> it's probably being ratelimited by some mail server).
> 

I acked just the single patches that hit cxgb3/cxgb4.  But if this is really
garbage, then ignore my ACKs...

Steve.