RE: [PATCH v4] pinctrl: samsung: Add support for pull-up and pull-down

["Vishnu Reddy" <vishnu.reddy@samsung.com>]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 04 August 2024 20:15
> To: Vishnu Reddy <vishnu.reddy@samsung.com>;
> s.nawrocki@samsung.com; alim.akhtar@samsung.com;
> linus.walleij@linaro.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; linux-gpio@vger.kernel.org; linux-
> kernel@vger.kernel.org; pankaj.dubey@samsung.com;
> ravi.patel@samsung.com; gost.dev@samsung.com
> Subject: Re: [PATCH v4] pinctrl: samsung: Add support for pull-up and pull-
> down
> 
> On 29/07/2024 17:36, Vishnu Reddy wrote:
> > Gpiolib framework has the implementation of setting up the PUD
> > configuration for GPIO pins but there is no driver support.
> >
> > Add support to handle the PUD configuration request from the userspace
> > in samsung pinctrl driver.
> >
> > Signed-off-by: Vishnu Reddy <vishnu.reddy@samsung.com>
> > ---
> 
> Where is the changelog? What happened with this patch?

Sorry, I missed to include changelog in all previous version of patches.
I will take care this part in future, below are the changelogs:

changes in v4:
- Update code in s5pv210_pud_value_init and s3c64xx_pud_value_init
functions for storing the pud values into array using macro names
instead of loop.
- Removed unnecessary and weird style comments.
- Updated proper comments.
- Fixed typo errors.
- Updated macro names based on suggestions which got in v3 review
comments.

changes in v3:
- Add new code to get the s5pv210 and s3c64xx and other exynos
series of pull down, pull up and disable values into an array and use
it in set config function for pud configuration.
- Add clock enable and disable setting while accessing registers.

changes in v2:
- Updated the macro names based on review comment that suggested
to follow the naming conventions according the file how previous macro
names defined.

Do let me know if I need to revise the patch or you are okay to consider
above changelog?

Regards,
Vishnu Reddy
> 
> Best regards,
> Krzysztof