Re: [patch] ARM: fix module-bound check in setting page attributes

["Hillf Danton" <hillf.zj@alibaba-inc.com>]

Ping

> -----Original Message-----
> From: Hillf Danton [mailto:hillf.zj@alibaba-inc.com]
> Sent: Tuesday, April 07, 2015 4:31 PM
> To: Hillf Danton; 'Laura Abbott'
> Cc: 'Russell King'; 'linux-kernel'; linux@arm.linux.org.uk
> Subject: Re: [patch] ARM: fix module-bound check in setting page attributes
> 
> Ping
> >
> > It was introduced in commit f2ca09f381a59
> > (ARM: 8311/1: Don't use is_module_addr in setting page attributes)
> >
> > We have no need to check start twice, but see if end is also in range.
> >
> > Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> > ---
> >
> > --- a/arch/arm/mm/pageattr.c	Wed Mar 25 11:55:13 2015
> > +++ b/arch/arm/mm/pageattr.c	Wed Mar 25 11:57:31 2015
> > @@ -52,7 +52,7 @@ static int change_memory_common(unsigned
> >  	if (start < MODULES_VADDR || start >= MODULES_END)
> >  		return -EINVAL;
> >
> > -	if (end < MODULES_VADDR || start >= MODULES_END)
> > +	if (end < MODULES_VADDR || end >= MODULES_END)
> >  		return -EINVAL;
> >
> >  	data.set_mask = set_mask;
> > --