From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C38C32143D
	for <linux-kernel@vger.kernel.org>; Mon, 11 May 2026 18:26:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778523998; cv=none; b=GjIj1PpAds0VvbYjZXglpOArR2zCsnvNIK50JxGEWkWCuEaZNGSsi0zWUl602O8DU8umlO/EAKHLTRTHZhoXY1pij+/TkCadNQCpKr9QDAGggiqHcxH4tpUUBhNJyFsvt6zw76GV8bQrDOsY6plH4CbwulAGUjHXV6tFaFsQ0iY=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778523998; c=relaxed/simple;
	bh=F4yALa9/mbx93iXUR1lV9RhmDxIVOyP5f3cddxveM0o=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=pXQzNFb4s93IHAjLMd1wLJOC+DuM6/lUqGmmFusCtuYyYnq1ZJiKsWAPYQ39D0ODZIsUi6OwNfeRUXLVpT0kibbGTmoNNmKlMHV1y7RbrIggMKNyC42SSBDCcYlwjoFHY1bUhZJRpJ2v7m6wARCZCiS2PQzQg56WmOR+Xdc0eOE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M4QdrK9j; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M4QdrK9j"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BA26C2BCB0;
	Mon, 11 May 2026 18:26:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1778523997;
	bh=F4yALa9/mbx93iXUR1lV9RhmDxIVOyP5f3cddxveM0o=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=M4QdrK9j7KL5ewkhJdjg3PFODsbRCUkpQlbz4xIVSd8cSmlJNYYY/e6UsBDawFvni
	 ft/BdUiSlweokt9yWedK+FWhXxkPs268g1yanFRM98Krgf8Zohc43lEqGmEsRWFX6Y
	 92uBrEMqWXVt5tFnYzm9mdGDzHneUjc90XCY4aoq3SLeBX6SUqe//A6iQjaMwOFTmB
	 uPOEciT/tppboWfsgqgIEgguUiKbHO7q3vsnjCkOmr+Uw9xsYnLzPkl5yTU5f0St2o
	 9QavZdDUdOVHxMBkMrMQlfYQk8N789j0JAhru4QCqAYbpryDxZLzkUTcXs3aSQVpPG
	 QMMu4kIL2PfVg==
Message-ID: <00d11da5-437e-4f3a-88cf-66ab0a729cd1@kernel.org>
Date: Mon, 11 May 2026 20:26:31 +0200
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 10/22] mm: introduce freetype_t
Content-Language: en-US
To: Brendan Jackman <jackmanb@google.com>, Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>,
 Peter Zijlstra <peterz@infradead.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 David Hildenbrand <david@kernel.org>, Wei Xu <weixugc@google.com>,
 Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
 Lorenzo Stoakes <ljs@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org,
 rppt@kernel.org, Sumit Garg <sumit.garg@oss.qualcomm.com>,
 derkling@google.com, reijiw@google.com, Will Deacon <will@kernel.org>,
 rientjes@google.com, patrick.roy@linux.dev,
 "Itazuri, Takahiro" <itazur@amazon.co.uk>, Andy Lutomirski
 <luto@kernel.org>, David Kaplan <david.kaplan@amd.com>,
 Thomas Gleixner <tglx@kernel.org>, Yosry Ahmed <yosry@kernel.org>
References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com>
 <20260320-page_alloc-unmapped-v2-10-28bf1bd54f41@google.com>
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
In-Reply-To: <20260320-page_alloc-unmapped-v2-10-28bf1bd54f41@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/20/26 19:23, Brendan Jackman wrote:
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -422,6 +422,37 @@ bool get_pfnblock_bit(const struct page *page, unsigned long pfn,
>  	return test_bit(bitidx + pb_bit, bitmap_word);
>  }
>  
> +/**
> + * __get_pfnblock_freetype - Return the freetype of a pageblock, optionally
> + * ignoring the fact that it's currently isolated.
> + * @page: The page within the block of interest
> + * @pfn: The target page frame number
> + * @ignore_iso: If isolated, return the migratetype that the block had before
> + *              isolation.
> + */
> +__always_inline freetype_t
> +__get_pfnblock_freetype(const struct page *page, unsigned long pfn,
> +			bool ignore_iso)

Hm I also noticed ignore_iso is ... ignored until later patch.

> +{
> +	int mt = get_pfnblock_migratetype(page, pfn);
> +
> +	return migrate_to_freetype(mt, 0);
> +}
> +
> +/**
> + * get_pfnblock_migratetype - Return the freetype of a pageblock
> + * @page: The page within the block of interest
> + * @pfn: The target page frame number
> + *
> + * Return: The freetype of the pageblock
> + */
> +__always_inline freetype_t
> +get_pfnblock_freetype(const struct page *page, unsigned long pfn)
> +{
> +	return __get_pfnblock_freetype(page, pfn, 0);

And here it passes 0 to bool.

> +}
> +
> +