public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Smith" <smithmg@agere.com>
To: "'Tommy Reynolds'" <reynolds@redhat.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: Unresolved symbol memset
Date: Wed, 5 Dec 2001 14:35:03 -0500	[thread overview]
Message-ID: <00d701c17dc3$f059db80$4d129c87@agere.com> (raw)
In-Reply-To: <20011205131659.3af1bafa.reynolds@redhat.com>

Taking your advice I removed the header memory.h and switched the
include for string.h to be linux/string.h.  This seemed to fix the
problem.  I thank you all for your input and appreciate the time you all
took

Michael

-----Original Message-----
From: linux-kernel-owner@vger.kernel.org
[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Tommy Reynolds
Sent: Wednesday, December 05, 2001 2:17 PM
To: Michael Smith
Cc: linux-kernel@vger.kernel.org
Subject: Re: Unresolved symbol memset

More important activities lacking, "Michael Smith" <smithmg@agere.com>
wrote:

> That particular header is included.  As I mentioned, I am using memset
> in other areas of the code, as well as the same file.  If I take this
> one call out of the source, it compiles, links and I am able to
perform
> and insmod correctly.  Below are the headers that are included in the
> file, and the area of the code that is causing the problem.  Let me
say
> that the code, even with this particular call in, compiles and links.
> The problem happens when I go to perform the insmod on it.
> 
> #include <memory.h>
> #include <string.h>
> #include "myownheaders.h"
> 
> 
> void myfunction( void *a, int len )
> {
> ....
> Mymemmove() //used because NdisMoveMemory can not be used
> memset( &a->WORD[NUMWORDS-len], 0, len*4);
> ...
> }

Inside a driver (or module) file, any include reference that doesn't
begin with
either <linux/foo.h> or <asm/foo.h> should always raise a red flag.
There are
user-land header files ("/usr/include") and kernel header files
("/usr/src/linux/include") and never the twain shall meet.

Mixing includes is always a bad idea.

-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- + -- -- -- -- -- -- -- --
-- --
Tommy Reynolds                               | mailto:
<reynolds@redhat.com>
Red Hat, Inc., Embedded Development Services | Phone:  +1.256.704.9286
307 Wynn Drive NW, Huntsville, AL 35805 USA  | FAX:    +1.256.837.3839
Senior Software Developer                    | Mobile: +1.919.641.2923


  reply	other threads:[~2001-12-05 19:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-05 18:18 Unresolved symbol memset Michael Smith
2001-12-05 18:26 ` rddunlap
2001-12-05 18:55   ` Michael Smith
2001-12-05 18:57     ` rddunlap
2001-12-05 19:16     ` Tommy Reynolds
2001-12-05 19:35       ` Michael Smith [this message]
2001-12-05 19:34     ` Charles Cazabon
2001-12-05 18:40 ` John Levon
2001-12-05 18:59   ` Michael Smith
2001-12-05 19:01     ` rddunlap
2001-12-05 19:09     ` Richard B. Johnson
2001-12-05 19:12       ` Michael Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00d701c17dc3$f059db80$4d129c87@agere.com' \
    --to=smithmg@agere.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reynolds@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox