* Redundant code?
@ 2003-06-02 15:32 Stuart MacDonald
2003-06-02 15:42 ` Brian Gerst
0 siblings, 1 reply; 3+ messages in thread
From: Stuart MacDonald @ 2003-06-02 15:32 UTC (permalink / raw)
To: linux-kernel
Seems to me the following is redundant code, since get_fd_set also
memsets the fds.res_* bitmaps.
..Stu
--- linux-2.5.70/fs/select.c 2003-05-26 21:00:21.000000000 -0400
+++ linux-2.5.70-new/fs/select.c 2003-06-02 11:40:24.000000000 -0400
@@ -344,9 +344,6 @@
(ret = get_fd_set(n, outp, fds.out)) ||
(ret = get_fd_set(n, exp, fds.ex)))
goto out;
- zero_fd_set(n, fds.res_in);
- zero_fd_set(n, fds.res_out);
- zero_fd_set(n, fds.res_ex);
ret = do_select(n, &fds, &timeout);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Redundant code?
2003-06-02 15:32 Redundant code? Stuart MacDonald
@ 2003-06-02 15:42 ` Brian Gerst
2003-06-02 15:58 ` Stuart MacDonald
0 siblings, 1 reply; 3+ messages in thread
From: Brian Gerst @ 2003-06-02 15:42 UTC (permalink / raw)
To: Stuart MacDonald; +Cc: linux-kernel
Stuart MacDonald wrote:
> Seems to me the following is redundant code, since get_fd_set also
> memsets the fds.res_* bitmaps.
>
> ..Stu
>
> --- linux-2.5.70/fs/select.c 2003-05-26 21:00:21.000000000 -0400
> +++ linux-2.5.70-new/fs/select.c 2003-06-02 11:40:24.000000000 -0400
> @@ -344,9 +344,6 @@
> (ret = get_fd_set(n, outp, fds.out)) ||
> (ret = get_fd_set(n, exp, fds.ex)))
> goto out;
> - zero_fd_set(n, fds.res_in);
> - zero_fd_set(n, fds.res_out);
> - zero_fd_set(n, fds.res_ex);
>
> ret = do_select(n, &fds, &timeout);
>
>
fds.in != fds.res_in
--
Brian Gerst
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: Redundant code?
2003-06-02 15:42 ` Brian Gerst
@ 2003-06-02 15:58 ` Stuart MacDonald
0 siblings, 0 replies; 3+ messages in thread
From: Stuart MacDonald @ 2003-06-02 15:58 UTC (permalink / raw)
To: 'Brian Gerst'; +Cc: linux-kernel
From: linux-kernel-owner@vger.kernel.org
> Stuart MacDonald wrote:
> > --- linux-2.5.70/fs/select.c 2003-05-26
> 21:00:21.000000000 -0400
> > +++ linux-2.5.70-new/fs/select.c 2003-06-02
> 11:40:24.000000000 -0400
> > @@ -344,9 +344,6 @@
> > (ret = get_fd_set(n, outp, fds.out)) ||
> > (ret = get_fd_set(n, exp, fds.ex)))
> > goto out;
> > - zero_fd_set(n, fds.res_in);
> > - zero_fd_set(n, fds.res_out);
> > - zero_fd_set(n, fds.res_ex);
> >
> > ret = do_select(n, &fds, &timeout);
>
> fds.in != fds.res_in
<smacks forehead> You are correct.
..Stu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-06-02 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-06-02 15:32 Redundant code? Stuart MacDonald
2003-06-02 15:42 ` Brian Gerst
2003-06-02 15:58 ` Stuart MacDonald
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox