From: Jungseung Lee <js07.lee@samsung.com>
To: heiko.carstens@de.ibm.com
Cc: js07.lee@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: RE: [PATCH] s390/compat: build error for large compat syscall args
Date: Thu, 21 Apr 2016 22:49:13 +0900 [thread overview]
Message-ID: <00ef01d19bd4$9710aec0$c5320c40$@samsung.com> (raw)
In-Reply-To:
Hello,
> s390/compat: build error for large compat syscall args
>
> Enforce 32 bit types for all compat syscall argument types.
>
> This way we can make sure that all arguments get correct sign
> or zero extension. Otherwise incorrect code would be generated.
>
> E.g. for a 'long' type the COMPAT_SYSCALL_DEFINE macro wouldn't
> generate code that would cause sign extension of the passed in 32
> bit user space parameter.
> This can cause quite subtle bugs like e.g. the one that was fixed
> with dfd948e32af2e "fs/compat: fix parameter handling for compat
> readv/writev syscalls".
include/linux/compat.h
#ifndef __SC_DELOUSE
#define __SC_DELOUSE(t,v) ((t)(unsigned long)(v)) #endif
We couldn't make sure that all compat syscall arguments has
32 bit types with default definition.
Is there any reason that this patch is only applied for s390?
Please let me know if I miss something.
BR
next reply other threads:[~2016-04-21 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:49 Jungseung Lee [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-21 13:37 [PATCH] s390/compat: build error for large compat syscall args Jungseung Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ef01d19bd4$9710aec0$c5320c40$@samsung.com' \
--to=js07.lee@samsung.com \
--cc=heiko.carstens@de.ibm.com \
--cc=js07.lee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox