From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753838AbdK3Qrb convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 11:47:31 -0500
Received: from opengridcomputing.com ([70.118.0.34]:34300 "EHLO
        smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753822AbdK3Qr2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 11:47:28 -0500
X-Greylist: delayed 341 seconds by postgrey-1.27 at vger.kernel.org; Thu, 30 Nov 2017 11:47:27 EST
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Colin King'" <colin.king@canonical.com>,
        "'Steve Wise'" <swise@chelsio.com>,
        "'Doug Ledford'" <dledford@redhat.com>,
        "'Jason Gunthorpe'" <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bharat@chelsio.com>
References: <20171130133006.19699-1-colin.king@canonical.com>
In-Reply-To: <20171130133006.19699-1-colin.king@canonical.com>
Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static
Date: Thu, 30 Nov 2017 10:41:50 -0600
Message-ID: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: 8BIT
X-Mailer: Microsoft Outlook 14.0
Content-Language: en-us
Thread-Index: AQH3RTnGEnie/UjMnvLYPYviJRRPY6LlaRfw
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer reg_workq is local to the source and does not need to be
> in global scope, so make it static.
> 
> Cleans up sparse warning:
> drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq'
> was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Looks correct.  This fixes a recent commit.

Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning")

Thanks,

Steve.