Re: [PATCH v2] gpiolib: Fix GPIO chip IRQ initialization restriction

Michael Walle
2023-06-15T09:26:26Z

Am 2023-06-07 16:12, schrieb Andy Shevchenko:
> +Cc: Michael
>
> On Wed, Jun 7, 2023 at 11:20 AM Jiawen Wu <jiawenwu@trustnetic.com>
> wrote:
>>
>> In case of gpio-regmap, IRQ chip is added by regmap-irq and associated
>> with
>> GPIO chip by gpiochip_irqchip_add_domain(). The initialization flag
>> was not
>> added in gpiochip_irqchip_add_domain(), causing gpiochip_to_irq() to
>> return
>> -EPROBE_DEFER.
>
> Makes sense to me.
> FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> But it would be nice to hear from Michael about this.

Thanks for bringing this to my attention. In fact, currently
my sl28cpld is broken due to this. So:

Reviewed-by: Michael Walle <michael@walle.cc>
Tested-by: Michael Walle <michael@walle.cc> # on kontron-sl28

>> Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members
>> before initialization")
>> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

-michael